? PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
5 Aug 2023

Summary of Changes

  • update build tools for multiple file output introduced with #40509 @dgrammatiko
  • update file includes/incompatible.html by run npm ci

Testing Instructions

check items of templates\system

Actual result BEFORE applying this Pull Request

a new folder (including a sub folder) is created by the build tools for error pages
image

Expected result AFTER applying this Pull Request

no extra folder like 4.3, 4.4

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 5 Aug 2023
Category JavaScript Repository
avatar heelc29 heelc29 - open - 5 Aug 2023
avatar heelc29 heelc29 - change - 5 Aug 2023
Status New Pending
avatar dgrammatiko
dgrammatiko - comment - 5 Aug 2023

LGTM

avatar richard67 richard67 - test_item - 6 Aug 2023 - Tested successfully
avatar richard67
richard67 - comment - 6 Aug 2023

I have tested this item successfully on 263c4da


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41321.

avatar richard67
richard67 - comment - 6 Aug 2023

@dgrammatiko Could you do a real test, too? Thanks in advance.

avatar dgrammatiko
dgrammatiko - comment - 7 Aug 2023

@richard67 I'm mostly on my phone these days and I don't have Codespaces enabled for Joomla, so kinda hard atm... sorry

avatar Quy Quy - test_item - 9 Aug 2023 - Tested successfully
avatar Quy
Quy - comment - 9 Aug 2023

I have tested this item successfully on 263c4da


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41321.

avatar Quy Quy - change - 9 Aug 2023
Status Pending Ready to Commit
Labels Added: PR-5.0-dev
avatar Quy
Quy - comment - 9 Aug 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41321.

avatar Quy Quy - change - 9 Aug 2023
Labels Added: ?
avatar HLeithner HLeithner - change - 11 Aug 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-08-11 08:37:18
Closed_By HLeithner
avatar HLeithner HLeithner - close - 11 Aug 2023
avatar HLeithner HLeithner - merge - 11 Aug 2023
avatar HLeithner
HLeithner - comment - 11 Aug 2023

thanks

Add a Comment

Login with GitHub to post a comment