Feeling Lucky
Feature
PR-5.0-dev
[#41320] - [5.0][Events] Finder event classes
- Fixed in Code Base
- 21 Aug 2023
- Medium
- Build: 5.0-dev
- # 41320
- Diff
- Fedik:finder-events2
User tests: Successful: Unsuccessful:
Summary of Changes
Implementing Event classes for Finder events.
The pr depend from #41226
Affected events:
- onFinderCategoryChangeState
- onFinderChangeState
- onFinderAfterDelete
- onFinderBeforeSave
- onFinderAfterSave
- onFinderResult
- onPrepareFinderContent
Testing Instructions
Apply patch.
Make sure finder plugins is enabled.
Try edit content, run indexer, use smart search.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
- Documentation link for docs.joomla.org: https://docs.joomla.org/Plugin/Events#Finder
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org: joomla/Manual#177
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_categories com_finder Front End com_content com_users Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
Feature
PR-5.0-dev
|
||
| Category | Administration com_categories com_finder Front End com_content com_users Libraries | ⇒ | Administration com_finder Front End Libraries Plugins |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-21 08:22:41 |
| Closed_By | ⇒ | HLeithner |
Hackwar
- comment
- 28 Aug 2023
It would have been cool, if you had actually tested the code... Right now, indexing via the smart search component does not work, since you missed half the events of those plugins. Hint: They don't extend the CMSPlugin class directly...
Hackwar
- comment
- 28 Aug 2023
Is this backwards compatible? Because the code you changed here is basically in all finder plugins by third party extensions.
hmm the prs conflict each other...