Feeling Lucky
Feature
PR-5.0-dev
b/c break
[#41297] - [5.0][Events] Module event classes
- Closed
- 21 Aug 2023
- Medium
- Build: 5.0-dev
- # 41297
- Diff
- Fedik:module-events
User tests: Successful: Unsuccessful:
Summary of Changes
Implementing Event classes for Module events.
The pr depend from #41226
Affected events:
- onRenderModule
- onAfterRenderModule
- onAfterRenderModules
- onPrepareModuleList
- onAfterModuleList
- onAfterCleanModuleList
Backward compatibility break (not critical):
Affects onAfterRenderModules.
Because its is imposible to pass the event attribute by reference the event listener now should use
$event->getContent() and $event->setContent($content) when need to modify the output.
Testing Instructions
Apply patch. Check all works
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
- Documentation link for docs.joomla.org: https://docs.joomla.org/Plugin/Events#Module
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org: TBD
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_users Front End com_content Libraries |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
| Category | Administration com_users Front End com_content Libraries | ⇒ | Administration com_categories com_users Front End com_content Libraries |
| Labels |
Added:
Feature
PR-5.0-dev
b/c break
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-21 08:03:01 |
| Closed_By | ⇒ | Fedik |
Git is messed up here, I made new PR #41413