PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
1 Aug 2023

Summary of Changes

The PR add deprecation warning about incorectly used event. Also some b/c code.

In general we should not use event object if there no event class for the event.
And so $event->getArgument(0) should not be used also.

When it realy realy realy need, then arguments should be accesed as foloving:

[$arg1, $arg2] = array_values($event->getArguments()); 

Testing Instructions

Apply patch.
Enable deprecation,
open some form in backend.
You should get deprecation warning "Numeric access to named event arguments is deprecated"
(make sure Schedule plugin is enabled)

Link to documentations

Please select:

  • Documentation link for docs.joomla.org: idk
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: tbd
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 1 Aug 2023
Category Libraries
avatar Fedik Fedik - open - 1 Aug 2023
avatar Fedik Fedik - change - 1 Aug 2023
Status New Pending
avatar Fedik Fedik - change - 1 Aug 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-08-01 16:18:24
Closed_By Fedik
Labels Added: PR-4.4-dev
avatar Fedik Fedik - close - 1 Aug 2023

Add a Comment

Login with GitHub to post a comment