Feeling Lucky
?
bug
PR-4.4-dev
[#41296] - [4.4] com_tags extra parent_id query var
- Fixed in Code Base
- 3 Nov 2023
- Medium
- Build: 4.3-dev
- # 41296
- Diff
- Denitz:patch-6
User tests: Successful: Unsuccessful:
Summary of Changes
parent_id query var is not stripped for the same view=tags menu item
Testing Instructions
- Create a menu item of 'Tags > List All Tags' type, select 'Root' in 'Parent_tag'.
- Ensure that you have any tags and tagged articles.
- Enable 'Show Tags' in any article menu item, click tag to access tag-specific page (
option=com_tags&view=tag) - Ensure that you have breadcrumbs displayed, see the menu item from p.1 with extra
parent_idquery params like https://site.com/tags?parent_id=1
Actual result BEFORE applying this Pull Request
Useless parent_id query var exists in the URL.
Expected result AFTER applying this Pull Request
parent_id query var is stripped if the menu item has the same parent_id
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | com_tags Front End |
| Status | New | ⇒ | Pending |
HLeithner
- comment
- 30 Sep 2023
This pull request has been automatically rebased to 4.4-dev.
| Title |
|
||||||
Quy
- comment
- 30 Oct 2023
I have tested this item ✅ successfully on da700a0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41296.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
bug
PR-4.4-dev
|
||
Quy
- comment
- 30 Oct 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41296.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Added:
?
Removed: ? |
||
MacJoom
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-11-03 15:28:43 |
| Closed_By | ⇒ | MacJoom | |
| Labels |
Added:
?
Removed: ? |
||
I have tested this item ✅ successfully on da700a0
I tested in 5.0.0-beta3-dev but I think the result is good for 4.x. Tricky to follow the instructions - made my head spin. Any way, in my two menu items with the patch applied I see
http://localhost/joomla-cms5/index.php/test-41926for a List All Tags menu item type andhttp://localhost/joomla-cms5/index.php/article-test-41296for a Single article menu item type. Without the patch the first ishttp://localhost/joomla-cms5/index.php/test-41926?parent_id=1This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41296.