PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
22 Jul 2023

Pull Request for #41065 (comment) .

Summary of Changes

This Pull Request (PR) fixes a mistake in the build/deleted_file_check.php script which I've made with my recently merged PR #41065 :

The files administrator/language/en-GB/plg_task_demotasks.ini and administrator/language/en-GB/plg_task_demotasks.sys.ini should be excluded from the list of deleted files, but that doesn't work because I've added them at the wrong place.

Testing Instructions

  1. On a clean, current 5.0-dev branch (no need for having run composer or npm and no need for a Joomla installation), download the following 2 Joomla 5.0 Alpha 1 and 2 full packages and save them in the tmp folder:
  1. Unzip the packages in the tmp folder into 2 separate folders Joomla_5.0.0-alpha1-Alpha-Full_Package and Joomla_5.0.0-alpha2-Alpha-Full_Package.
  2. In a command windows in the directory with your git clone and the branch from step 1, run the following command to check the two folders from the previous step for deleted files and folders (on Windows you have to use backslashes \ instead of slashes / for the paths):
php ./build/deleted_file_check.php --from=./tmp/Joomla_5.0.0-alpha1-Alpha-Full_Package --to=./tmp/Joomla_5.0.0-alpha2-Alpha-Full_Package
  1. Check the 2 created text files ./build/deleted_files.txt and ./build/deleted_folders.txt.
    Result: See section "Actual result BEFORE applying this Pull Request" below.
  2. Save the 2 text files from step 4 for later comparison.
  3. Apply the changes from this PR.
  4. Repeat steps 3 and 4 and compare the 2 text files with those saved in step 5.
    Result: See section "Expected result AFTER applying this Pull Request" below.

Actual result BEFORE applying this Pull Request

File ./build/deleted_files.txt still contains 2 rows '/administrator/language/en-GB/plg_task_demotasks.ini', and '/administrator/language/en-GB/plg_task_demotasks.sys.ini',.

File ./build/deleted_folders.txt is empty.

Expected result AFTER applying this Pull Request

File ./build/deleted_files.txt doesn't contain '/administrator/language/en-GB/plg_task_demotasks.ini', and '/administrator/language/en-GB/plg_task_demotasks.sys.ini',.

Besides that, it doesn't differ to the file saved in step 5 without this PR applied.

File ./build/deleted_folders.txt is empty, same as without this PR.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 22 Jul 2023
Category Repository
avatar richard67 richard67 - open - 22 Jul 2023
avatar richard67 richard67 - change - 22 Jul 2023
Status New Pending
avatar richard67 richard67 - change - 22 Jul 2023
The description was changed
avatar richard67 richard67 - edited - 22 Jul 2023
avatar HLeithner HLeithner - change - 22 Jul 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-07-22 12:30:34
Closed_By HLeithner
Labels Added: PR-5.0-dev
avatar HLeithner HLeithner - close - 22 Jul 2023
avatar HLeithner HLeithner - merge - 22 Jul 2023
avatar HLeithner
HLeithner - comment - 22 Jul 2023

thanks

Add a Comment

Login with GitHub to post a comment