Language Change PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
23 Jul 2023

Summary of Changes

It's going to be more and more important to be able to know if the Backward Compatibility Plugin is enabled or not.

This PR adds it to the list of information displayed in the system information page

Testing Instructions

Apply the PR and you will now be able to see if the plugin is enabled or disabled when you so the system dashboard and click on system information

image

Link to documentations

Please select:

  • [] Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 23 Jul 2023
Category Administration com_admin Language & Strings
avatar brianteeman brianteeman - open - 23 Jul 2023
avatar brianteeman brianteeman - change - 23 Jul 2023
Status New Pending
avatar brianteeman brianteeman - change - 23 Jul 2023
Labels Added: Language Change PR-5.0-dev
avatar HLeithner
HLeithner - comment - 23 Jul 2023

the options active in the plugin would also be useful

avatar brianteeman
brianteeman - comment - 23 Jul 2023

the options active in the plugin would also be useful

Doesnt really fit with the system info page which is just an overview

avatar HLeithner
HLeithner - comment - 23 Jul 2023

add the parameter names (which are active) in a () comma separated list should work

avatar brianteeman
brianteeman - comment - 23 Jul 2023

sorry I dont know how to get the active params for the plugin using the pluginhelper

avatar HLeithner
HLeithner - comment - 23 Jul 2023

I added the parameters, you can adapt them if you don't like the style.

avatar HLeithner HLeithner - close - 23 Jul 2023
avatar HLeithner HLeithner - change - 23 Jul 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-07-23 20:07:10
Closed_By HLeithner
avatar HLeithner HLeithner - change - 23 Jul 2023
Status Closed New
Closed_Date 2023-07-23 20:07:10
Closed_By HLeithner
avatar HLeithner HLeithner - change - 23 Jul 2023
Status New Pending
avatar HLeithner HLeithner - reopen - 23 Jul 2023
avatar brianteeman
brianteeman - comment - 23 Jul 2023

Enabled (classes_aliases:"0", es5_assets:"1")

That looks wrong

there is an error in the plugin that this has exposed see #41214

6a4cd61 23 Jul 2023 avatar brianteeman cs
avatar wilsonge
wilsonge - comment - 24 Jul 2023

When people test this can we make sure we test the JSON view exports too please.

avatar brianteeman
brianteeman - comment - 24 Jul 2023

json export is fine

image

avatar HLeithner HLeithner - change - 24 Jul 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-07-24 11:40:34
Closed_By HLeithner
avatar HLeithner HLeithner - close - 24 Jul 2023
avatar HLeithner HLeithner - merge - 24 Jul 2023
avatar HLeithner
HLeithner - comment - 24 Jul 2023

thanks

avatar brianteeman
brianteeman - comment - 24 Jul 2023

thanks

Add a Comment

Login with GitHub to post a comment