NPM Resource Changed PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
22 Jul 2023

Pull Request for several closed issues

Summary of Changes

When an option in a select list is disabled it is not visually displayed any differently to an enabled option. You just can't select/highlight it

Although we dont have any examples (that I am aware of) in the core of this there are many extensions that do. Usually when there are "pro" options that are disabled in a regular version.

This PR just adds a slight background to the disabled option

Testing Instructions

This is an scss change so you will need to either test with a prebuilt package or run npm run build:css

Then edit administrator\components\com_content\forms\article.xml and add the following line as an additional option for the Status Field
<option value="3" disabled="disabled">Disabled</option>

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • [ x Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 22 Jul 2023
Category Repository NPM Change
avatar brianteeman brianteeman - open - 22 Jul 2023
avatar brianteeman brianteeman - change - 22 Jul 2023
Status New Pending
avatar richard67
richard67 - comment - 22 Jul 2023

@brianteeman Could you check the scss code style errors reported here: https://ci.joomla.org/joomla/joomla-cms/67747/1/29

8843f1b 22 Jul 2023 avatar brianteeman cs
avatar brianteeman brianteeman - change - 22 Jul 2023
Labels Added: NPM Resource Changed PR-4.4-dev
avatar laoneo laoneo - close - 17 Aug 2023
avatar laoneo laoneo - merge - 17 Aug 2023
avatar laoneo laoneo - change - 17 Aug 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-08-17 08:19:08
Closed_By laoneo
avatar laoneo
laoneo - comment - 17 Aug 2023

Thanks!

avatar brianteeman
brianteeman - comment - 17 Aug 2023

As much as I am happy that this has been merged there have been zero tests

avatar Quy
Quy - comment - 22 Aug 2023

This can be seen in the core with Workflows.

workflow-disabled

Add a Comment

Login with GitHub to post a comment