NPM Resource Changed bug PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar GeraintEdwards
GeraintEdwards
15 Jun 2023

Pull Request for Issue # .

Summary of Changes

Change handling of 'button' interactive type to respond to the button click rather than immediately executing.

This execution happens at the start of the tour and not when the step has actually been reached and so the modal setup ends up being called twice. As a result other steps with interactive actions e.g. checkboxes or text input fields cannot be interacted with.

Testing Instructions

Create a tour as per following screenshots - a JSON import is attached if you have implemented the tours import/export PR #40645

backdropProblemTour.zip

Screenshot 2023-06-15 at 13-01-58 Guided Tours Edit Tour - Joomla Tours - Administration

Screenshot 2023-06-15 at 13-02-20 Guided Tours Edit Step - Joomla Tours - Administration

Screenshot 2023-06-15 at 13-02-29 Guided Tours Edit Step - Joomla Tours - Administration

Screenshot 2023-06-15 at 13-02-38 Guided Tours Edit Step - Joomla Tours - Administration

Screenshot 2023-06-15 at 13-02-46 Guided Tours Edit Step - Joomla Tours - Administration

Screenshot 2023-06-15 at 13-02-56 Guided Tours Edit Step - Joomla Tours - Administration

Unpublish steps 3 and 4 so that you have this as an overview

Screenshot 2023-06-15 at 13-11-57 Guided Tour Guided Tours Modal Backdrop Problem - Joomla Tours - Administration

Now run the tour

Actual result BEFORE applying this Pull Request

At step 2 you have a double backdrop and can't interact with the checkbox

Screenshot 2023-06-15 at 13-12-36 Articles Categories - Joomla Tours - Administration

If you enable steps 3 and 4 it behaves even worse

Screenshot 2023-06-15 at 13-13-54 Articles Categories - Joomla Tours - Administration

and if you proceed with clicking the rebuild button you get stuck in a loop.

Expected result AFTER applying this Pull Request

Screenshot 2023-06-15 at 13-14-59 Articles Categories - Joomla Tours - Administration

You also don't get a loop on the rebuild button action step

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • [x ] No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • [ x] No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 15 Jun 2023
Category JavaScript Repository NPM Change
avatar GeraintEdwards GeraintEdwards - open - 15 Jun 2023
avatar GeraintEdwards GeraintEdwards - change - 15 Jun 2023
Status New Pending
avatar GeraintEdwards GeraintEdwards - change - 15 Jun 2023
Labels Added: NPM Resource Changed PR-5.0-dev
avatar GeraintEdwards GeraintEdwards - change - 16 Jun 2023
Labels Added: bug
avatar GeraintEdwards GeraintEdwards - change - 21 Jun 2023
Title
[5.0] Record currentStepId in sessionStorage when responding to an interact…
[5.0] Guided Tours - Record currentStepId in sessionStorage when responding to an interact…
avatar GeraintEdwards GeraintEdwards - edited - 21 Jun 2023
avatar HLeithner
HLeithner - comment - 9 Jul 2023

@sdwjoomla since you create some guided tours could you please test this pr

avatar GeraintEdwards
GeraintEdwards - comment - 14 Jul 2023

Reissued as PR for Joomla 4.3 #41155

avatar GeraintEdwards GeraintEdwards - close - 14 Jul 2023
avatar GeraintEdwards GeraintEdwards - change - 14 Jul 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-07-14 14:11:19
Closed_By GeraintEdwards

Add a Comment

Login with GitHub to post a comment