[#40775] - [5.0] Select all columns in extensions uninstallation on update
- Fixed in Code Base
- 16 Jun 2023
- Medium
- Build: 5.0-dev
- # 40775
- Diff
- richard67:5.0-dev-extend-uninstallation-on-update-2023-06-15
User tests: Successful: Unsuccessful:
Pull Request for #40768 (comment) .
Summary of Changes
With my just merged PR #40768 , extensions uninstallation with optional parameter migration on update was implemented in 5.0-dev.
But the enabled status of the extension is not passed to the migration function, so that function can not work differently depending on that status. There might also be other columns in the extensions table which might be of interest of a migration function.
This PR here fixes that by selecting all columns with the database query, so the $row object passed to the migration function contains them all.
Testing Instructions
Code review should be enough.
Actual result BEFORE applying this Pull Request
The extensions uninstallation with parameter migration on update passes only the extension_id and the params properties of the extension to the migration function.
Expected result AFTER applying this Pull Request
The extensions uninstallation with parameter migration on update passes all properties of the extension to the migration function.
Link to documentations
Please select:
-
No documentation changes for docs.joomla.org needed
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_admin |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-5.0-dev
|
||
is there a reason why we don't load all columns?
@HLeithner You mean with a SELECT * FROM ...? Not really a reason, except maybe that when specifying columns explicitly I can see in the code which columns I have. We won't need all of them, but selecting all is of course better for code maintainability, one secret place less to change. If you want I can do that.
please change it to * thanks
| Title |
|
||||||
please change it to * thanks
Done, and title and description changed accordingly.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-06-16 11:25:35 |
| Closed_By | ⇒ | HLeithner |
thanks
is there a reason why we don't load all columns?