User tests: Successful: Unsuccessful:
Disabling Quick Icon Display and adding correct text definitions and Joomla 5 links
Pull Request for Issue # .
Changed announcement texts to approved wording
Changed links to Joomla 5
Commented out QuickIcon display code
Edit Line 42 'private const EOS_DATE = '2025-10-17'; and change 2025 to 2023
As well as the banner appearing a quickicon in the box near Joomla Update would appear
The quickicon no longer appears
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Category | ⇒ | Administration Language & Strings Front End Plugins |
Status | New | ⇒ | Pending |
Labels |
Added:
Language Change
PR-4.4-dev
|
Why this icon twice? That makes it messy.
Because the code is wrong :)
Disabling Quick Icon Display ...
You removed the quickicon functionality. The plugin is still called <name>plg_quickicon_eos</name>
and group="quickicon"
The naming of this plugin no longer corresponds to what the plugin shows. Is the naming still correct? Is there possibly a better alternative?
This plugin works now in a similar way as the php EOS plugin. So for now it is ok to have it in the quickicon group. On some point we need to move it to a new group.
I have tested this item
Banner works fine, tested all the dates.
Hi! Thanks for your work!
I've got a few things:
1. in eos.php:
line 217, 231, 245: link should be https://docs.joomla.org/Special:MyLanguage/Joomla_4.4.x_to_5.x_Planning_and_Upgrade_Step_by_Step
line 273: link should go to https://joomla.org/5
Will you please fix those links?
2. in the language strings:
line 10 PLG_QUICKICON_EOS_MESSAGE_ERROR_SUPPORT_ENDED="
Support has ended for your version of Joomla. <a href="%2$s" target="_blank" rel="noopener noreferrer">Migrate to the next version as soon as possible.
"line 14 PLG_QUICKICON_EOS_MESSAGE_INFO_02="
When is the time to migrate to the next version? Once the extensions your site needs are compatible. Learn <a href="%2$s" target="_blank" rel="noopener noreferrer">how to use the Pre-Update Checker.
"line 16 PLG_QUICKICON_EOS_MESSAGE_WARNING_SECURITY_ONLY="
This version of Joomla has entered security only mode. Support ends %1$s. Start <a href="%2$s" target="_blank" rel="noopener noreferrer">planning to migrate to the next version of Joomla today.
"line 18 PLG_QUICKICON_EOS_MESSAGE_WARNING_SUPPORT_ENDING="
Support ends on %1$s for this version of Joomla. <a href="%2$s" target="_blank" rel="noopener noreferrer">Migrate to the latest version of Joomla as soon as possible.
"Ok, I think that's it :) Thank YOU!!
@bayareajenn It is more effective to click on the relevant line in the code and add the suggestion.
@bayareajenn It is more effective to click on the relevant line in the code and add the suggestion.
Yes, I'm sure it is. Sadly, I don't know how. I don't really know how to use github. I was in the code in the site. I didn't even think of going to the code in the PR. I'm not a developer. I apologise. The formatting went to poo even worse once I commented.
Yes, I'm sure it is. Sadly, I don't know how. I don't really know how to use github......
Very understandable.
Click on the link, as indicated below with the red arrow at the top of this page. You will then arrive at the relevant files. And follow the instructions I indicated above.
Yes, I kinda got it and started adding them. Then realised that the nightly I was working off of is different from the files in here. So now I'm just thoroughly confused. I'm now unsure of what is correct and what isn't. So I'll sleep on it and work with the team. Thank you for teaching me @sandewt. I will get better over time.
Hi Everyone. The version Jenn downloaded was the previous version before this PR. I have checked and these files are the correct ones with the correct language definitions and links.
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-06-24 11:20:55 |
Closed_By | ⇒ | MacJoom |
Thanks