Feature Language Change NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar beni71
beni71
16 May 2023

Pull Request for Issue #23185 .

Summary of Changes

In the articles view there is a batch action which can add/assign one tag from the tag list to the selected articles. This PR introduces the possibility to remove/unassign one tag from the selected articles. It also extends batch processing for categories, contacts and news feeds.

How it looks like:

articles-batch-tag-removing

Testing Instructions

  1. Make sure your Joomla tag system is active and the plugin "Behaviour - Taggable" is enabled.
  2. Create a new article and in the detail view add/assign two tags, lets say "Tag1" and "Tag2".
  3. Save and create a second article, add/assign it to tag "Tag2" and "Tag3".
  4. Save and close.
  5. In the articles list select both articles, click batch action and remove "Tag2". Apply batch processing.
  6. Open the first article details and check whether the "Tag2" is removed. The tag "Tag1" must be still assigned.
  7. Open the second article details and check whether the "Tag2" is removed. The tag "Tag3" must be still assigned.
  8. A similar test should be done for categories, contacts and news feeds.

Actual result BEFORE applying this Pull Request

It is not possible to remove/unassign a tag from an article via batch processing.

Expected result AFTER applying this Pull Request

It is possible to remove/unassign a tag from an article via batch processing.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

There are new text keys that need to be translated.

avatar joomla-cms-bot joomla-cms-bot - change - 16 May 2023
Category Administration Language & Strings JavaScript Repository NPM Change Layout Libraries Front End Plugins
avatar beni71 beni71 - open - 16 May 2023
avatar beni71 beni71 - change - 16 May 2023
Status New Pending
avatar beni71 beni71 - change - 16 May 2023
Labels Added: Language Change NPM Resource Changed PR-4.3-dev
avatar beni71 beni71 - change - 16 May 2023
The description was changed
avatar beni71 beni71 - edited - 16 May 2023
avatar beni71 beni71 - change - 16 May 2023
The description was changed
avatar beni71 beni71 - edited - 16 May 2023
avatar brianteeman
brianteeman - comment - 16 May 2023

This is a new feature isn't it?

avatar richard67
richard67 - comment - 16 May 2023

This is a new feature isn't it?

@brianteeman To me it seems so, and the referred issue also was labelled as feature and not as bug. Am just clarifying with other maintainers what they think.

avatar beni71 beni71 - change - 16 May 2023
Labels Added: Feature
avatar richard67
richard67 - comment - 16 May 2023

@beni71 Thank you very much for this PR. Due to our development roadmap, new features will go into version 5.0. Before you get shocked now: 5.0 will be released at the same time as 4.4 in October this year.

4.4 will serve as a bridge version for updating to 5 in the same way as the 3.10 was for 4, so we don't include new features into 4.4 if they are not needed for a smooth update to 5.

4.3.0 had feature freeze when it was in beta phase, and with patch versions we do not include new features in general.

This all for your understanding so you are not too disappointed.

Could you rebase this PR to 5.0-dev? Let us know here if you need help or advise with that.

Or maybe it is better if you create a new branch based on the 5.0-dev branch and make the PR again with that new branch, so your 4.3-dev branch will not be rebased to 5.0-dev because that could be confusing in future.

Thanks in advance.

avatar beni71
beni71 - comment - 17 May 2023

Ok, so I can close this PR.

avatar beni71 beni71 - close - 17 May 2023
avatar beni71 beni71 - change - 17 May 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-05-17 07:44:09
Closed_By beni71
avatar richard67
richard67 - comment - 17 May 2023

New PR for 5.0-dev is #40613 . Thanks @beni71 .

Add a Comment

Login with GitHub to post a comment