[#40610] - Fix for TypeError: count() in webservices when running PHP 8.x
- Fixed in Code Base
- 20 Jul 2023
- Medium
- Build: 4.3-dev
- # 40610
- Diff
- MacJoom:WebservicesGroupIssue
User tests: Successful: Unsuccessful:
The error occurs when doing webservices API POST call to /fields/groups/contacts/contact or /fields/groups/content/articles
Pull Request for Issue # .
Summary of Changes
Is_array test before doing count() - not needed FieldsHelper::extract returns null if there are not two parts
Testing Instructions
Code review -
or do test the webservices test with Postman and the collection from here:
https://github.com/alexandreelise/j4x-api-collection
Actual result BEFORE applying this Pull Request
TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in /var/www/clients/client2/web3/web/joomla-cms/administrator/components/com_fields/src/Model/GroupModel.php:247 etc.
Expected result AFTER applying this Pull Request
No Error, Item is added
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
[x ] No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
[x ] No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.3-dev
|
||
| Title |
|
||||||
i've got a different error with postman without your PR
PHP Warning: Trying to access array offset on value of type null in /joomla-cms/administrator/components/com_fields/src/Model/GroupModel.php on line 244
btw applying the pr no more error
tested fields/groups/contacts/contact too
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40610.
| Labels |
Added:
PHP 8.x
bug
?
|
||
The change looks ok, but I'm wondering why the context there is null?
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-07-20 14:04:55 |
| Closed_By | ⇒ | obuisard |
Yes OK - then we do not need to do a count again. I was just focusing on the part throwing the error... - and the section is not optional but mandatory