? ? PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar Kaushik1216
Kaushik1216
15 May 2023

Test added for tags listview

avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2023
Category JavaScript Unit Tests
avatar Kaushik1216 Kaushik1216 - open - 15 May 2023
avatar Kaushik1216 Kaushik1216 - change - 15 May 2023
Status New Pending
avatar rajputanuj31
rajputanuj31 - comment - 15 May 2023

use npm run lint:js -- --fix command.

avatar Kaushik1216
Kaushik1216 - comment - 15 May 2023

this command will lead to change in other files too

avatar Kaushik1216 Kaushik1216 - change - 15 May 2023
Labels Added: ? PR-4.4-dev
avatar laoneo
laoneo - comment - 15 May 2023

There are still some code style issues. This is the command we do run during the Ci pipeline eslint --config build/.eslintrc --ext .js tests/System. When you add the --fix open as @rajputanuj31 suggested, it will fix the issues automatically.

avatar Kaushik1216 Kaushik1216 - change - 15 May 2023
Labels Added: ?
avatar laoneo laoneo - change - 15 May 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-05-15 14:14:12
Closed_By laoneo
avatar laoneo laoneo - close - 15 May 2023
avatar laoneo laoneo - merge - 15 May 2023
avatar laoneo
laoneo - comment - 15 May 2023

Thanks!

Add a Comment

Login with GitHub to post a comment