Feature No Code Attached Yet
avatar bmankowski
bmankowski
15 May 2023

Steps to reproduce the issue

Switch editor to Codemirror in global configuration.
During editing in Codemirror press "Ctrl+/" to comment a line or block.

Expected result

Line/block should be commented.

Actual result

Nothing happens.

System information (as much as possible)

Tried on freshly installed joomla 4 instalation, and asked on Joomla forum to check the scenario:
https://forum.joomla.org/viewtopic.php?f=814&t=1001653
and the other person had the same result.

Additional comments

avatar bmankowski bmankowski - open - 15 May 2023
avatar bmankowski bmankowski - change - 15 May 2023
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 15 May 2023
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 15 May 2023
avatar brianteeman
brianteeman - comment - 15 May 2023

Why do you expect that behaviour?
Can you replicate it on a codemirror demo from the codemirror.net site?

avatar bmankowski
bmankowski - comment - 16 May 2023

@brianteeman I expect this behavior because in https://codemirror.net/docs/ref/#commands "ctrl+/" is stated as "Ctrl-/ (Cmd-/ on macOS): toggleComment." Tried it in Joomla4 and as it doesn't work I filed this tikcet. Could you check if it works for you?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40595.
avatar bmankowski
bmankowski - comment - 16 May 2023

On https://codemirror.net/ it works normally.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40595.

avatar brianteeman
brianteeman - comment - 16 May 2023

The links you shared are for codemirror v6. Joomla is currently using v5.
I checked the demos for v5 and unless I am missing something it is not a feature of v5
https://codemirror.net/5/demo/fullscreen.html

avatar bmankowski
bmankowski - comment - 16 May 2023

In https://codemirror.net/5/doc/manual.html#commands it mention it's possible to use comment/comment.js
And in fact it's already in /media/vendor/codemirror/addon/comment
I just don't have a knowledge to bind it to a key.
Do you think it's worth to make this change, or do you think it's better to just wait for next version of codemirror to be introduced to Joomla v4?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40595.

avatar richard67 richard67 - change - 16 May 2023
Labels Added: Feature
avatar richard67 richard67 - labeled - 16 May 2023
avatar Fedik Fedik - change - 21 Aug 2023
Status New Closed
Closed_Date 0000-00-00 00:00:00 2023-08-21 18:08:30
Closed_By Fedik
avatar Fedik Fedik - close - 21 Aug 2023
avatar Fedik
Fedik - comment - 21 Aug 2023

It is working in Joomla 5 with Codemirror 6 #41070

Add a Comment

Login with GitHub to post a comment