? NPM Resource Changed bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
13 May 2023

Pull Request for Issue #40481 .

Summary of Changes

Restoring feature, that was broken in 4.x (#34870)
https://docs.joomla.org/Calendar_form_field_type
min/max year is relative numbers.

Testing Instructions

Apply patch, run npm install
Please follow #40481
Or create a custom calendar field, somewhere in XML:

<field type="calendar" name="cal1" label="Calendar test" minyear="-1" maxyear="1"/>

And check which year is available to select.

Actual result BEFORE applying this Pull Request

It display year 1

Expected result AFTER applying this Pull Request

It allows to select years: 2022, 2023, 2024

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 13 May 2023
Category JavaScript Repository NPM Change
avatar Fedik Fedik - open - 13 May 2023
avatar Fedik Fedik - change - 13 May 2023
Status New Pending
avatar Fedik Fedik - change - 13 May 2023
The description was changed
avatar Fedik Fedik - edited - 13 May 2023
avatar richard67 richard67 - test_item - 13 May 2023 - Tested successfully
avatar richard67
richard67 - comment - 13 May 2023

I have tested this item successfully on 2d69e00


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40580.

avatar dgrammatiko dgrammatiko - test_item - 13 May 2023 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 13 May 2023

I have tested this item successfully on 2d69e00


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40580.

avatar richard67 richard67 - change - 13 May 2023
Status Pending Ready to Commit
Labels Added: NPM Resource Changed bug PR-4.3-dev
avatar richard67
richard67 - comment - 13 May 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40580.

avatar obuisard obuisard - change - 13 May 2023
Labels Added: ?
avatar obuisard obuisard - close - 13 May 2023
avatar obuisard obuisard - merge - 13 May 2023
avatar obuisard obuisard - change - 13 May 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-05-13 14:45:26
Closed_By obuisard
avatar obuisard
obuisard - comment - 13 May 2023

Thank you Fedir @Fedik for the PR!

Add a Comment

Login with GitHub to post a comment