[#40581] - [4.3] Language of parts bug
- Fixed in Code Base
- 14 May 2023
- Medium
- Build: 4.3-dev
- # 40581
- Diff
- brianteeman:langset
User tests: Successful: Unsuccessful:
Pull Request for Issue #40568 .
Summary of Changes
Testing Instructions
Go to the TinyMCE plugin and add a Language of Parts item but leave the fields blank.
Save and go to edit an article.
Also test after the PR that you can still add a language of parts without error
Actual result BEFORE applying this Pull Request
Error page:
array_merge(): Argument #1 must be of type array, null given
JROOT/plugins/editors/tinymce/src/PluginTraits/DisplayTrait.php:393
Expected result AFTER applying this Pull Request
No error
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | New | ⇒ | Pending |
I have tested this item
Decided my previous comment was stupid. Patch works fine on 4.3.1.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40581.
I have tested this item
Works as described.
However, isn't it an issue that the plugin settings form allows to save an empty language of parts? Could that be fixed with another PR?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40581.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
bug
PR-4.3-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40581.
However, isn't it an issue that the plugin settings form allows to save an empty language of parts? Could that be fixed with another PR?
I think that is a generic issue with the repeatable field
| Labels |
Added:
?
|
||
Thank you Brian @brianteeman for the PR!
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-14 18:31:55 |
| Closed_By | ⇒ | obuisard |
thanks
Testing on 4.3.1 - patch works fine. So I should pass this. But...
Testing this on 4.2.10-dev with the patch applied, I get
call to a member function getIdentity() on null
1 () JROOT/plugins/editors/tinymce/src/PluginTraits/DisplayTrait.php:71
2 PlgEditorTinymce->onDisplay() JROOT/libraries/src/Editor/Editor.php:194
I applied the patch, added the empty Language of Parts, then went to Article edit. New error appears.
Reverted LofP and Patch - back to normal.
That maybe irrelevant but I though it best to mention it before reporting a pass.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40581.