[#40556] - End of support plugin
- Closed
- 9 May 2023
- Medium
- Build: 4.4-dev
- # 40556
- Diff
- mfleeson:End-of-Support-Plugin
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Rewriting the 3.10 End of Service Notification and placing it into Joomla 4 coding structure and style.
Simplified the language definitions to not be hardcoded for 3 to 4
Currently using const EOS_DATE = '2023-10-25'; in file plugins/quickicon/eos/src/Extension/Eos.php The correct date should be 2025-10-25 but then the notification does not appear.
Dimitris converted the jQuery code into working javascript for closing the notification and also calling the com_ajax so the hide me is stored in the plugin parameters.
Testing Instructions
Build.
Check plg_quickicon_eos is enabled.
View Home Dashboard in the back end.
Actual result BEFORE applying this Pull Request
No notification is displayed
Expected result AFTER applying this Pull Request
A notification is displayed
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
[x ] No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change Front End Plugins |
| Status | New | ⇒ | Pending |
| Category | JavaScript Repository NPM Change Front End Plugins | ⇒ | Administration Language & Strings JavaScript Repository NPM Change Front End Plugins |
| Labels |
Added:
NPM Resource Changed
PR-4.4-dev
|
||
| Labels |
Added:
Language Change
|
||
Complete SQL stuff for new installations and updates is missing, and the plugin is also missing in the extensions helper.
Richard has informed me I need to include it in the extensions table and the ExtensionHelper so I'll take a look at that tomorrow and then rerequest the PR.
| Category | JavaScript Repository NPM Change Front End Plugins Administration Language & Strings | ⇒ | SQL Administration com_admin Language & Strings JavaScript Repository NPM Change Installation Postgresql Libraries Front End Plugins |
| Labels |
Added:
Feature
|
||
| Category | JavaScript Repository NPM Change Front End Plugins Administration Language & Strings SQL com_admin Installation Postgresql Libraries | ⇒ | SQL Administration com_admin Postgresql JavaScript com_media NPM Change Language & Strings Repository Installation Libraries Front End Plugins |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-09 16:05:18 |
| Closed_By | ⇒ | mfleeson |
Why closed PR and deleted branch?
I'm sorry I didn't realise it had done that. I thought I was working on my local fork. I was trying to get all of the files back into one place. I didn't delete the branch, just renamed it as I realised it was based on 4.3 and not 4.4. So I created a new fork based on 4.4 and have used a comparison to put all of the code into the new fork. I was going to make sure it adheres to all of these comments and then push that. Git is still very much a black art to me.
Then I think you have to make a new PR with the renamed branch. If you do that, please refer to this PR here in the description of the new PR so people can find previous discussions.
Git is still very much a black art to me.
Maybe Github Destop is a good alternative. I read there "Focus on what matters instead of fighting with Git."
I recently started using this program (on Windows) for my own github repositories to gain experience with it. It works quite simple.
I was using github desktop, that's the scary thing but it wasnt updating with other peoples changes so it totally overwrote Dimitri's javascript code.
Thanks for the info. Good to know.
All requested changes have been made. Thanks.