[#40557] - Custom fields in contact mails are rendered with HTML
- Fixed in Code Base
- 14 May 2023
- Medium
- Build: 4.3-dev
- # 40557
- Diff
- Digital-Peak:contact/layouts
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #40338.
Summary of Changes
This pr restores the behavior that custom fields in mails are rendered without HTML code. It was like that forever but the pr #37716 broke it.
Testing Instructions
- Create a normal contact custom field
- Create a contact mail custom field
- Create a contact with an email address and fill in a value into the custom field
- Create a contact menu item the new contact selected
- Open the contact details page
- Send a mail to the contact via the web form
You can also do the testing instructions from #37716 to ensure that the contact data is rendered like an article.
Actual result BEFORE applying this Pull Request
The custom field is rendered like on articles. The mail which got sent to the contact contains some HTML output.
Expected result AFTER applying this Pull Request
The custom field is rendered like on articles. The mail which got sent to the contact contains no HTML output.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
| Status | New | ⇒ | Pending |
Yes it fixes, thanks for the hint, updated.
We should probably remove the lines, where do we delete these files in the script..?
We should probably remove the lines, where do we delete these files in the script..?
@laoneo I leave it to you if you do that with this PR or if I do it with my PR for script.php, but if I do it and the merge of my PR takes longer, the functionality might be broken when people update with nightly builds, so maybe you should fix that here.
| Category | Front End com_contact | ⇒ | Administration com_admin Front End com_contact |
| Labels |
Added:
bug
PR-4.3-dev
|
||
Thanks for the hint @Kostelano !
@laoneo It needs to remove also the deleted folders in script.php here:
joomla-cms/administrator/components/com_admin/script.php
Lines 7923 to 7926 in 3f468ad
@richard67 thanks
| Labels |
Added:
Release Blocker
|
||
@laoneo I've just tested, also with the testing instructions from PR #37716 . What I've noticed is that when using a subform field in the mail context, i.e. the contact form, the email still contains some HTML markup, just less as before. I don't know how that's been in 4.2.8 or older before that PR had been merged, I haven't tested that yet with 4.2.8.
Besides this, everything works as expected, i.e. the contact fields and the article fields look the same, and when using single fields and not subforms for the contact form, there is no HTML markup in the email.
It is probably the same on 4.2.8. All this pr does is to remove the markup around the field. But the subform probably adds some more markup to align the fields. So this should be fixed in another pr.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40557.
Testet, the Fix works...
Testet, the Fix works...
@Uwe-MrT Could you mark your test result in the issue tracker? Just go to https://issues.joomla.org/tracker/joomla-cms/40557 and use the blue "Test this" button at the top left corner, then select your test result (success) and submit. Thanks in advance.
I have tested this item
Works for me
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40557.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40557.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-14 16:58:23 |
| Closed_By | ⇒ | obuisard | |
| Labels |
Added:
?
|
||
Thanks Allon @laoneo for the PR and Richard @richard67 for looking into it!
@laoneo As far as I understand this PR solves issue #40338 . If that is right. please refer to that issue in the description. Thanks in advance.