While I agree with this change, this is differing from the behavior all other core components have.

While I agree with this change, this is differing from the behavior all other core components have.

Perhaps but then again com_tags is not the same as any other component

this is differing from the behavior all other core components have

Maybe have to unset Itemid somewhere? but I cannot find how other component doing it

I found that other components doing it

The other components are doing it the way it is now. That is why I'm saying this. And com_tags is crap, but it is otherwise the same as all other core components.

I have tested this item ✅ successfully on e8e8af8

Before Test

https://bugsfun.jdayusa.com/site6/index.php/de/component/tags/tag/testd?Itemid=101

After Patch

https://bugsfun.jdayusa.com/site6/index.php/de/component/tags/tag/testd

@Hackwar What do you think if I just do unset($query['Itemid']) in build(), that will be better or? (when option !== com_tags)

I have tested this item ✅ successfully on e8e8af8

Thank you for this perfect patch ?????

RTC

Hi

I have similar issue. Wrong tab links after migration
I have also open a post in the Joomla forum without answer.

To follow my issue
go to each page links and click on tag France

Site Joomla 3.2.9 (PHP 8) - Site test (come from a backup)
(https://biomecaniquej4.en-toutes-lettres.fr/fr/carte/cartographie-labo-formation/81-laboratoires-de-biomecanique/382-auctus-inria-ims "J429 382-auctus-inria-ims")

the tag link alias is
/fr/tags-pays/france
and it is OK, I can navigate with all tags. I have created 3 dedicated menu links for each Main tags.

I take Same Site after migraion to Joomla 4.3.0 (Live Site Migration Done yesterday, PHP 8.1)
(https://www.biomecanique.org/fr/carte/cartographie-labo-formation/81-laboratoires-de-biomecanique/382-auctus-inria-ims "J430 382-auctus-inria-ims")
the tag link alias is now
/fr/component/tags/tag/france?Itemid=106
Not OK, go to Home page, menu Id=106

Same Site (Test) migrate to Joomla 4.3.0 but with your Batch (PHP 8 site Test)
I modify file Router.php folowing Github info.
(https://biomecanique.en-toutes-lettres.fr/fr/carte/cartographie-labo-formation/81-laboratoires-de-biomecanique/382-auctus-inria-ims "J430 Batch 382-auctus-inria-ims")

the tag link alias is now
/fr/component/tags/tag/france
Not OK, go to Home page too.
The itemid are removed by the batch (Thnks) but the link is always wrong

Thanks for your support

Bertrand

/fr/tags-pays/france was be the good link
"tags-pays" alias of the menu tag (all tag list - Tag Parent Pays)
"france" alias of the tag France in Tag Parent Pays

@tramber91 Are you sure that you have applied the changes from this patch correctly? Have you also removed the code at the top, lines 130 to 138, the complete if block with the comment telling it goes to the home page? See first red block in the diff:

Yes, I have removed the block and replace the 2 lines

Then there is maybe something else wrong on your site.

Thanks, If you have an idea where to search?
Same Community Joomla website works with 4.2.9 for alias tag links, but no more with 4.3.0. :=(
I don't see any parameter to modified in Joomla. I have no override. My menus and components are OK and update !!
Seems to be a com_tag component issue

I applied the patch.
It dose remove the itemid=104, but if you use pagination in com_tags it brings it's back on the next page - /component/tags/tag/tagname?Itemid=104&start=xx

I have confirmed the problem @tramber91 reported. Thank you for reporting!

Please test #40455, it redo of this PR with fixing for Pagination

@tramber91 If I not mistaken, your issue related to changes betwen 3 and 4 versions of Joomla.
There something with Multilanguage, the tag list should have menu for each language, or something like that.
I found that it does not pick the tag menu wich set to All on multilang site.

@Fedik It seems the issue is confirmed and not related to a difference between 3.10 and 4 but between 4.2 and 4.3. Could you check this new issue #40454 ? Thanks in advance.

I could reproduce the issue of the changing links, but not the issue with the broken links (this afternoon i was sure i had a broken link)

@tramber91 please test changes from another PR #40460

@Fedik

Did the test but same issue (Not working on my side)

same link (see below after the batch)
/fr/component/tags/tag/france?Itemid=106

should be (like in Joomla version 4.2)
/fr/tags-pays/france

I add/Change new codes in initial Router.php file (4.3.0)

i also did the test with SEF diseable
Without alias
result is
/index.php?option=com_tags&view=tag&id[0]=7:france&Itemid=106&lang=fr
Should be
/index.php?option=com_tags&view=tag&id[0]=7:france&Itemid=2622&lang=fr

the router not found the menu id 2622 (Menu Tags: All tags parent Id Countries (Pays))
https://biomecanique.en-toutes-lettres.fr/fr/tags-pays?parent_id=4
If you start from this link (above), you select Tag "France", you have list of article with tag "France"
You select one article and click on France tag
You move to Home page instead of page with tag="France "we have just seen before.

I did also the test including previous batch modification. Same think but without the ?Itemid=106

@tramber91 Could you add your last comment to the pull request #40460 instead of this closed issue? Thanks in advance.