[#40449] - [4.3] Guided Tours disabled plugin
- Fixed in Code Base
- 26 Jul 2023
- Medium
- Build: 4.3-dev
- # 40449
- Diff
- brianteeman:4.3-dev-friday_2
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
If the system guided tours plugin is disabled then the tours do not work
This simple pr adds a notice in the component if the plugin is disabled
Testing Instructions
Disable the system plugin for guided tours
Open the guided tours component
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
| Status | New | ⇒ | Pending |
You are welcome to add additional changes
So what do you think, does it make sense? Is it correct english?
"The Guided Tours System Plugin is disabled. Please enable the “Guided Tours System Plugin” in System » Plugins for full functionality."
I would either keep it as is or enhance it by direcvtly linking to the plugin manager as is done with the redirect and smart search but the code in guidedtours was too different for me to do that.
| Labels |
Added:
Language Change
PR-4.3-dev
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40449.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40449.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40449.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-07-26 18:55:40 |
| Closed_By | ⇒ | wilsonge |
Thanks
Thanks!
I tested this successful but I am not sure about the message.
How about directing the user where and what to do?
So instead: The Guided Tours System Plugin is disabled. The Guided Tours module will not be displayed if this is not enabled.
Something like: Please enable the "The Guided Tours System Plugin" in System » Plugins for full functionality.
Why full functionality? If you say you have to enable the plugin to display the module, the user can be confused if the module is then still not displayed because the module could be unpublished too. Or we have to check for both to be enabled and published.
Hope it makes sense.