[#40447] - [4.3] guided tours module count
- Fixed in Code Base
- 14 Jul 2023
- Medium
- Build: 4.3-dev
- # 40447
- Diff
- brianteeman:4.3-dev=pbf1
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Changes the way tours are counted in the module. The result is the same but without the warning about unreachable code
Testing Instructions
Check to make sure that there are a maximum of 7 tours in the module dropdown
Change the count in the module and check that the dropdown is changed correctly
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.3-dev
|
||
Sorry for not being clear. The warning about unreachable code will only be seen in an ide. You just need to follow the test instructions to confirm that after the changed code the count still works
I have tested this item
Tested Successfully - Count still works after applying the patch
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40447.
Thank you @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40447.
Another way is to add the following after line 55:
$listTours = array_slice($listTours, 0, $params->get('tourscount', 7));
and remove:
<?php if ($i >= $params->get('tourscount', 7)) : ?>
<?php break; ?>
<?php endif; ?>
I created a pull request for you brianteeman#496
@HLeithner there are lots of unrelated changes in your pr
@HLeithner there are lots of unrelated changes in your pr
only code style and revert to what it was before, but you can just pick what you need and commit it your self. I don't need to be mentioned.
I will look tomorrow. I don't use the computer on Saturday
| Labels |
Added:
bug
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40447.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40447.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40447.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-07-14 21:23:17 |
| Closed_By | ⇒ | obuisard |
Thank you Brian @brianteeman for the PR!
I do not have a warning before applying the patch. How can I reproduce it? (Error Reporting is set to maximum)