[#40398] - [4.3] clear button in list view is not disabled when no "filter" is active
- Fixed in Code Base
- 25 Apr 2023
- Medium
- Build: 4.3-dev
- # 40398
- Diff
- dgrammatiko:patch-7
User tests: Successful: Unsuccessful:
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Status | New | ⇒ | Pending |
| Labels |
Added:
NPM Resource Changed
PR-4.3-dev
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40398.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40398.
This needs to be merged and included in 4.3.1
But I don't have the huge amount of data to check the out of memory aspect.
Try to use https://github.com/nikosdion/overload
Anyway this PR here has deserved the release blocker label because the issue with the unwanted reset of the ordering and the list limit fields has been introduced with 4.3.0, in 4.2.9 it was ok.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40398.
Unfortunately this is not complete
Scenario 1
Clear button not enabled by default
Scenario 2
Clear button enabled when filter is set
Scenario 3
Clear button when selected correctly applies the default list limit
It does display the number in the select box BUT the limit is not applied
@brianteeman I can confirm your finding for the core list view, e.g. content/categories. With the patchtester's list view it works.
As the PR originally claimed only to solve issue #40378 , it is successful regarding this, but not regarding the other issue #40475 .
Quite a matter of taste now if we lave this PR RTC and solve the other issue with another one, or if we remove RTC here and ask for a fix with this PR here. @dgrammatiko What would you prefer?
What would you prefer?
Let's tackle it here, give me couple of hours as I'm in the middle of some other work right now
| Status | Ready to Commit | ⇒ | Pending |
Back to pending. PR will be updated later to handle also issue #40475 . See previous comments.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40398.
| Labels |
Added:
Release Blocker
bug
|
||
I have tested this item
Solves issue #40378 and as far as I can see (not enough data to cause the memory run out) also issue #40475 .
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40398.
Tested and solves issue #40475 for me too! Great job team!
@Attila-SWE Have you also checked if the reset button is inactive when there is no filter selected, and active when there is one? If so, I would call it a successful test. Could you go to the PR in the issue tracker here https://issues.joomla.org/tracker/joomla-cms/40398 , then use the blue "Test this" button at the top left corner, then select your test result (success) and finally submit? Thanks in advance.
I have tested this item
Replaced media/system/js/searchtools.js from compiled file. Clear button inactive when no filter applied and no more issue with displaying all entries when clearing search.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40398.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40398.
I have tested this item
Successfully tested
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40398.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-25 13:57:33 |
| Closed_By | ⇒ | obuisard | |
| Labels |
Added:
?
|
||
Yes, indeed, great job, thanks Dimitris @dgrammatiko and all for looking into it.
I have tested this item✅ successfully on 37d4ca9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40398.