User tests: Successful: Unsuccessful:
Pull Request for Issue #40393 .
Fix the logic
follow the issue
This should be a release blocker
Category | ⇒ | JavaScript Repository NPM Change |
Status | New | ⇒ | Pending |
Labels |
Added:
NPM Resource Changed
PR-4.3-dev
|
you can not use patch tester for this type of pull request.
I have tested this item
I've tested as described in my comment to the issue here: #40393 (comment)
I have tested this item
After applying the patch and rebuilding javascript the check button worked. Thanks to richard for providing the sql commands to simulate an overide in the template
Status | Pending | ⇒ | Ready to Commit |
RTC
you can not use patch tester for this type of pull request.
You can use patch tester for PR's with the tag "NPM Resource changed" only if you have setup a local environment for Joomla as described here: https://docs.joomla.org/J4.x:Setting_Up_Your_Local_Environment/en - then the file(s) to be patched exist
and you need to do npm ci
- or even jinstall
after the patch
you can not use patch tester for this type of pull request.
You can use patch tester for PR's with the tag "NPM Resource changed" only if you have setup a local environment for Joomla as described here: https://docs.joomla.org/J4.x:Setting_Up_Your_Local_Environment/en - then the file(s) to be patched exist
You really can't. People using patchtester expect to apply the patch and then be able to test - even with the files in their environment there is still a lot more to do. Far better to tell them the correc5t advice as provided by @richard67
or even jinstall after the patch
that's a new one???
or even jinstall after the patch
that's a new one???
@brianteeman I think he means making a new installation of Joomla e.g. when a PR has changed in SQL scripts for new installations.
or even jinstall after the patch
that's a new one???
Not really it's described in https://docs.joomla.org/J4.x:Setting_Up_Your_Local_Environment/en - a batch command that does composer install
and npm ci
seriously? ;)
if you are using patchtester then you almost certainly not in a position to create a bash alias script
a script which btw is hopelessy out of date
Labels |
Added:
?
Release Blocker
bug
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-25 14:20:22 |
Closed_By | ⇒ | obuisard |
Thanks Dimitris @dgrammatiko for the fix and all for testing!
I just tried to test this using the Patch Tester component and got this message:
"There are no files to patch from this pull request. This may mean that the files in the pull request are not present in your installation."
My overrides are in a custom template, not Cassiopeia