No Code Attached Yet bug
avatar RickR2H
RickR2H
13 Apr 2023

Steps to reproduce the issue

In the latest 4.3 nightly build I noticed that on saving a module there is now 3 times Save & Close present in the dropdown. Just open the dropdown in a module and you can see the result.

screen shot 2023-04-13 at 08 12 50

Expected result

The two options in the dropdown should be Save & New and Save as Copy.

avatar RickR2H RickR2H - open - 13 Apr 2023
avatar RickR2H RickR2H - change - 13 Apr 2023
Labels Removed: ?
avatar RickR2H RickR2H - labeled - 13 Apr 2023
avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2023
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 13 Apr 2023
avatar RickR2H RickR2H - change - 13 Apr 2023
The description was changed
avatar RickR2H RickR2H - edited - 13 Apr 2023
avatar brianteeman
brianteeman - comment - 13 Apr 2023

confirmed. I think I know which PR broke this. will check and submit a pr very shortly

avatar RickR2H
RickR2H - comment - 13 Apr 2023

Thanks @brianteeman I'll test when you have a patch!

avatar brianteeman
brianteeman - comment - 13 Apr 2023

Forgot I had a meeting all morning - oops. So maybe someone else can fix this first.

This is the PR that broke it #39537 from @wilsonge

avatar richard67 richard67 - change - 13 Apr 2023
Labels Added: bug
avatar richard67 richard67 - labeled - 13 Apr 2023
avatar richard67 richard67 - change - 13 Apr 2023
Labels Removed: J4 Issue
avatar richard67 richard67 - unlabeled - 13 Apr 2023
avatar richard67 richard67 - change - 13 Apr 2023
Title
3 times Save & Close in module Save & Close dropdown
[4.3] 3 times Save & Close in module Save & Close dropdown
avatar richard67 richard67 - edited - 13 Apr 2023
avatar obuisard
obuisard - comment - 13 Apr 2023

This is not a translation problem, the childbar actions are all set to 'save' when they should be set to 'save', 'save2new' and 'save2copy'.

This is a release blocker in my opinion.

avatar brianteeman
brianteeman - comment - 13 Apr 2023

It's caused by the changes in the pr from George

avatar obuisard obuisard - change - 13 Apr 2023
Labels Added: Release Blocker
avatar obuisard obuisard - labeled - 13 Apr 2023
avatar joomdonation
joomdonation - comment - 14 Apr 2023

Please test PR #40381. Thanks !

avatar joomdonation joomdonation - change - 14 Apr 2023
Status New Closed
Closed_Date 0000-00-00 00:00:00 2023-04-14 01:37:20
Closed_By joomdonation
avatar joomdonation joomdonation - close - 14 Apr 2023
avatar richard67 richard67 - change - 14 Apr 2023
Labels Removed: Release Blocker
avatar richard67 richard67 - unlabeled - 14 Apr 2023

Add a Comment

Login with GitHub to post a comment