Joomla! Issue Tracker | Joomla! CMS #40378 - [4.3] clear button in list view is not disabled when no "filter" is active

No Code Attached Yet bug

Closed
16 Apr 2023
Medium
Build: 4.3-dev
# 40378

heelc29
13 Apr 2023

Steps to reproduce the issue

open any list view (eg. plugins)

Expected result

J4.2.10-dev: clear button is disabled

Actual result

J4.3.0-rc4-dev: clear button is not disabled

Additional comments

This behavior is broken with #39772 @dgrammatiko by adding the if condition mainContainer

joomla-cms/build/media_source/system/js/searchtools.es6.js

Lines 373 to 382 in 99fadde

    
           getFilterFields() { 
        
             if (this.mainContainer) { 
        
               return Array.prototype.slice.call(this.mainContainer.querySelectorAll('select,input')); 
        
             } 
        
             if (this.filterContainer) { 
        
               return Array.prototype.slice.call(this.filterContainer.querySelectorAll('select,input')); 
        
             } 
        
             return []; 
        
           }

and so now evaluation for filter fields also include the ordering (which are maybe always are active)

joomla-cms/build/media_source/system/js/searchtools.es6.js

Lines 305 to 313 in 99fadde

    
           this.getFilterFields().forEach((item) => { 
        
             if (item.classList.contains('active')) { 
        
               activeFilterCount += 1; 
        
               if (cont.filterButton) { 
        
                 cont.filterButton.classList.remove('btn-secondary'); 
        
                 cont.filterButton.classList.add('btn-primary'); 
        
               } 
        
             } 
        
           });

heelc29 - open - 13 Apr 2023

joomla-cms-bot - change - 13 Apr 2023

Labels

Added: No Code Attached Yet

joomla-cms-bot - labeled - 13 Apr 2023

richard67 - change - 13 Apr 2023

Labels

Added: bug

richard67 - labeled - 13 Apr 2023

chmst - comment - 16 Apr 2023

I do not think that this is a bug. In J3 the clear button was always active and I used it also to clear the search input field.

brianteeman - comment - 16 Apr 2023

Sorry to disagree but it is a bug. In Joomla 4.2 the button is always disabled UNLESS a filter is selected OR a search term is used.

chmst - comment - 16 Apr 2023

I was missing this feature from J3. But indeed the button was disabled in former J4 versions.

brianteeman - comment - 16 Apr 2023

I was missing this feature from J3.

it is still there (after a search)

richard67 - comment - 16 Apr 2023

Closing as having a pull request. Please test #40398 . Thanks in advance.

richard67 - change - 16 Apr 2023

Status	New	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2023-04-16 22:15:33
Closed_By		⇒	richard67

richard67 - close - 16 Apr 2023

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#40378] - [4.3] clear button in list view is not disabled when no "filter" is active

Steps to reproduce the issue

Expected result

Actual result

Additional comments

Add a Comment

	getFilterFields() {
	if (this.mainContainer) {
	return Array.prototype.slice.call(this.mainContainer.querySelectorAll('select,input'));
	}
	if (this.filterContainer) {
	return Array.prototype.slice.call(this.filterContainer.querySelectorAll('select,input'));
	}

	return [];
	}

	this.getFilterFields().forEach((item) => {
	if (item.classList.contains('active')) {
	activeFilterCount += 1;
	if (cont.filterButton) {
	cont.filterButton.classList.remove('btn-secondary');
	cont.filterButton.classList.add('btn-primary');
	}
	}
	});