[#40377] - [4.3] update help toc
- Fixed in Code Base
- 14 May 2023
- Medium
- Build: 4.3-dev
- # 40377
- Diff
- heelc29:4.3/help-toc
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #40271 .
@obuisard Issue is a Release Blocker
Summary of Changes
run build/helpTOC.php
New entries:
- Guided Tours: New or Edit Step
- Guided Tours: New or Edit Tour
- Guided Tours: Steps
- Guided Tours
- Joomla Update
Renamed (because they are redirects):
Testing Instructions
Check entries are present (administrator/index.php?option=com_admin&view=help)
Note: help links are still failing at the moment (see #39818)
Actual result BEFORE applying this Pull Request
No links for Guided Tours in help site
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration |
| Status | New | ⇒ | Pending |
Could you explain this please
Sure, the docs sites for these keys are redirections (to still valid help pages) and so will be not found by the build tool.
If the target of the reditection should be find by the build tool we have to replace the language strings in com_admin (but not 1 week before release). So I manually copy these keys back in the json file.
I thought that is what you might mean :(
Up to the release leads but I would not be in favour of this approach. The script should build the json file correctly. If that means changes then so be it. We shouldn't use such hacky approaches as this just because of the date.
Thanks for this PR, this is something we neclected for the past releases.
As we're too close to the release to get this into 4.3.0 we have now 5 weeks to get it in the clean way for 4.3.1.
Ok, I will update this PR
One question: is there a reason why the json file is not pretty formatted, this would help at code review?
| Category | Administration | ⇒ | Administration com_contact com_content com_fields com_modules com_newsfeeds Language & Strings |
| Labels |
Added:
PR-4.3-dev
|
||
| Labels |
Added:
Language Change
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40377.
Almost but not quite
Almost but not quite
Seems @ceford moved page Help4.x:Guided Tours: Tours to Help4.x:Guided Tours
PR updated
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40377.
richard67
- alter_testresult
- 14 May 2023
- https://github.com/joomla/joomla-cms/pull/40377: Tested successfully
richard67
- alter_testresult
- 14 May 2023
- https://github.com/joomla/joomla-cms/pull/40377: Not tested
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40377.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40377.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-14 17:50:28 |
| Closed_By | ⇒ | obuisard |
Could you explain this please