[#4032] - [#34013] Fix add/remove selected attribute and class
- Closed
- 19 Dec 2015
- Medium
- Build: staging
- # 4032
- Diff
- itbra:patch-21
- Foreign ID 34013
- Error The Travis CI build could not complete due to an error Details
User tests: Successful: Unsuccessful:
Currently the chosen.jquery plugin doesn't properly handle the adding/removing of the class 'result-selected' and attribute 'selected="selected"' when list elements are changed (single-select-list) or added/removed (multi-select-list). Its current implementation leaves the class 'result-selected' attached to any previously selected list element thus making to handle the specific selected item by an onchange-handler impossible when trying to catch the selected element via its 'result-selected' class.
The fix solves this issue and properly adds/removes the mentioned class and attribute to every involved element and allows to post-process exactly only the currently selected element(s) by an onchange-handler.
| Labels |
Added:
?
?
|
||
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
Removed: ? |
||||||
| Status | New | ⇒ | Pending |
nicksavov
- | Labels |
Removed:
?
|
||
| Category | ⇒ | External Library JavaScript |
jissues-bot
- | Title |
|
||||||
| Title |
|
||||||
I tested this fix by adding/removing elements of a list in "debug" plugin options. After fix, chosen.jquery plugin still behaves the same way. It successfully handles for the first removal of a list object. But if you try adding and removing new ones, result-selected class is not handled correctly.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4032.
I have tested the patch, but adding/removing of new ones aren´t handled correctly.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4032.
| Status | Pending | ⇒ | Information Required |
@itbra Can you please have a look at the unsuccessful test results? In addition fix the merge conflicts? Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4032.
Hello @spignataro
Thank you for your contribution.
The last comment here was on August 21st. So the question is, Is this issue/pull request still valid?
If no reply is received within 4 weeks we will close this issue.
Thanks for understanding!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4032.
@spignataro or a beer :) I must have been reading another ticket of yours. Indeed it's @itbra :)
Have two one me!!!
Now back to ticket work. ;-)
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-12-19 13:00:31 |
| Closed_By | ⇒ | brianteeman |
I am closing this at this time as there have been no responses to the failed tests. It can always be reopened when resolved
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4032.
| Title |
|
||||||
joomla-cms-bot
- | Title |
|
||||||
Associated bug tracker item