[#4031] - Create aes.php
- Closed
- 7 Oct 2014
- Medium
- Build: staging
- # 4031
- Diff
- sarciszewski:patch-3
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
AES is MCRYPT_RIJNDAEL_128, but supports keys of 16, 24, or 32 bytes.
Closes #3827
Testing instructions:
- Not using Rijndael256 thinking it's AES256.
- Using AES with a 256-bit key would be AES256.
Done.
I honestly have no clue what you're talking about. I know it's about some encryption but where is it used and how could someone who doesn't know that stuff test it? You need to provide some testing instructions for non-developers to get some testing done.
And also some explanations what you try to do. Not everyone knows all the encryption algorythms 
Can you provide that?
http://stackoverflow.com/questions/4128497/picking-encryption-cipher-for-mcrypt/19737721#19737721
As far as testing goes, I don't have any test vectors off-hand and I'm kind of in a hurry. Maybe ask @ircmaxell?
Massive -1.
Is there really a need for everyone to invent their own crypto and re-implement it? You can't use an existing implementation like Zend\Crypt???
My end goal in this PR was to rm this: https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/crypt/cipher/rijndael256.php
brianteeman
- | Status | New | ⇒ | Pending |
nicksavov
- | Labels |
Removed:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-07 14:28:10 |
Please add some testing instructions and informations what you try to achieve here. Thanks.