Feeling Lucky
?
bug
PR-4.4-dev
[#40317] - [4.4] replace deprecated joomla/string inflector
- Fixed in Code Base
- 27 Apr 2023
- Medium
- Build: 4.4-dev
- # 40317
- Diff
- heelc29:4.4/joomla-string/inflector
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
The following functions (used by core) are deprecated and will (maybe) be removed in joomla/string 3.0
Inflector->toPlural(): Use Doctrine\Common\Inflector\Inflector::pluralize() instead.
Inflector->toSingular(): Use Doctrine\Common\Inflector\Inflector::singularize() instead.
Testing Instructions
open article edit view and click close button
ListView is not used by core -> code review or own component
Actual result BEFORE applying this Pull Request
you will be redirected to articles list view
Expected result AFTER applying this Pull Request
you will be redirected to articles list view
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
bug
PR-4.4-dev
|
||
| Category | Libraries | ⇒ | Libraries JavaScript Unit Tests |
| Labels |
Added:
?
|
||
MacJoom
- comment
- 26 Apr 2023
I have tested this item
Tested with the Banners Component which uses the FormController from the library
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40317.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-27 14:56:11 |
| Closed_By | ⇒ | laoneo |
laoneo
- comment
- 27 Apr 2023
Thanks!
Can you try to add a system test which tests the cancel action to here https://github.com/joomla/joomla-cms/blob/4.4-dev/tests/System/integration/administrator/components/com_content/Article.cy.js, so we know the library is at least working the way we expect.