Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#40316] - Restore cache feature in category module

? PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
3 Apr 2023

Pull Request for pr #39527.

Summary of Changes

Restores the cache feature which got lost by the merge from #39527.

Testing Instructions

  • Create an instance of the module Articles Category
  • Open the front end

Actual result BEFORE applying this Pull Request

It shows some articles.

Expected result AFTER applying this Pull Request

It shows some articles.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 3 Apr 2023
Category ⇒ Modules Front End
avatar laoneo laoneo - open - 3 Apr 2023
avatar laoneo laoneo - change - 3 Apr 2023
Status New ⇒ Pending
avatar carlitorweb carlitorweb - test_item - 3 Apr 2023 - Tested successfully
avatar carlitorweb
carlitorweb - comment - 3 Apr 2023

I have tested this item ✅ successfully on 115a158

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40316.

avatar joomla-cms-bot joomla-cms-bot - change - 4 Apr 2023
Category Modules Front End ⇒ Libraries Modules Front End
avatar laoneo laoneo - change - 4 Apr 2023
Labels Added: PR-4.4-dev
avatar laoneo laoneo - change - 4 Apr 2023
The description was changed
avatar laoneo laoneo - edited - 4 Apr 2023
346b27b 4 Apr 2023 avatar laoneo cs
avatar laoneo
laoneo - comment - 4 Apr 2023

Can you have another look as I basically moved the load from cache function to the abstract module dispatcher.

avatar joomla-cms-bot joomla-cms-bot - change - 4 Apr 2023
Category Modules Front End Libraries ⇒ Modules Front End
avatar laoneo laoneo - change - 4 Apr 2023
The description was changed
avatar laoneo laoneo - edited - 4 Apr 2023
avatar laoneo
laoneo - comment - 4 Apr 2023

Reverted the deprecation change and made a new pr in #40325.

avatar joomdonation
joomdonation - comment - 4 Apr 2023

This works. However, the code looks a bit mess. I suggest to move the code which get Category ID ($idBase variable in current code) to a separate private method getCategoryId so that the method getLayoutData look cleaner.

avatar laoneo
laoneo - comment - 5 Apr 2023

I would leave it as it is as it is then more inline with the previous function, so other developers will recognize that the logic from the old module file goes into the dispatcher.

avatar laoneo
laoneo - comment - 5 Apr 2023

@joomdonation can you give this a test, so we can merge and then @carlitorweb can update his other pull requests the same way?

avatar joomdonation joomdonation - test_item - 5 Apr 2023 - Tested successfully
avatar joomdonation
joomdonation - comment - 5 Apr 2023

I have tested this item ✅ successfully on 33dba3f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40316.

avatar joomdonation joomdonation - change - 5 Apr 2023
Status Pending ⇒ Ready to Commit
avatar joomdonation
joomdonation - comment - 5 Apr 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40316.

avatar MacJoom MacJoom - change - 6 Apr 2023
Labels Added: ?
avatar MacJoom MacJoom - change - 6 Apr 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-04-06 11:25:04
Closed_By ⇒ MacJoom
avatar MacJoom MacJoom - close - 6 Apr 2023
avatar MacJoom MacJoom - merge - 6 Apr 2023

Add a Comment

Login with GitHub to post a comment