? PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
3 Apr 2023

Summary of Changes

Migrate com_messages "My Settings" button and divider to new toolbar API
more information: #39537

Testing Instructions

open Private Messages and check My Settings in toolbar (function and display)
image

Actual result BEFORE applying this Pull Request

deprecate message from toolbar
Joomla\CMS\Toolbar\Toolbar::appendButton() should only accept Joomla\CMS\Toolbar\ToolbarButton instance

Expected result AFTER applying this Pull Request

no deprecate message from toolbar and button still works

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 3 Apr 2023
Category Administration com_messages
avatar heelc29 heelc29 - open - 3 Apr 2023
avatar heelc29 heelc29 - change - 3 Apr 2023
Status New Pending
avatar brianteeman brianteeman - test_item - 3 Apr 2023 - Tested successfully
avatar brianteeman
brianteeman - comment - 3 Apr 2023

I have tested this item successfully on 9ea0ac1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40315.

avatar Quy Quy - test_item - 3 Apr 2023 - Tested successfully
avatar Quy
Quy - comment - 3 Apr 2023

I have tested this item successfully on 9ea0ac1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40315.

avatar Quy Quy - change - 3 Apr 2023
Status Pending Ready to Commit
Labels Added: PR-4.4-dev
avatar Quy
Quy - comment - 3 Apr 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40315.

avatar MacJoom MacJoom - change - 3 Apr 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-04-03 17:50:12
Closed_By MacJoom
Labels Added: ?
avatar MacJoom MacJoom - close - 3 Apr 2023
avatar MacJoom MacJoom - merge - 3 Apr 2023
avatar MacJoom
MacJoom - comment - 3 Apr 2023

Thank you!

Add a Comment

Login with GitHub to post a comment