[#40314] - phan: Fixes to Helper classes
- Fixed in Code Base
- 4 Apr 2023
- Medium
- Build: 4.4-dev
- # 40314
- Diff
- Hackwar:4.3-phan-helper
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
This is another block of fixes to our code based on results from phan static code analysis. This time I went through the classes in the /libraries/src/Helper folder.
In the ModuleHelper, the first variable is overwritten a few lines further down without being used, while the second variable might not be set when being used later on. In the TagsHelper, the parameters of the strpos() are mixed up, making it return false everytime and thus calling that createTagsFromField each time, even though it is not necessary.
Testing Instructions
Codereview
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.4-dev
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-04 07:25:24 |
| Closed_By | ⇒ | laoneo |
Thanks!