[#40287] - [5.0] Update versions in codemirror.xml and tinymce.xml
- Fixed in Code Base
- 2 Apr 2023
- Medium
- Build: 5.0-dev
- # 40287
- Diff
- richard67:5.0-dev-update-codemirror-and-tinymce-xml-files
User tests: Successful: Unsuccessful:
Pull Request for Issue #40285 .
Summary of Changes
This pull request (PR) updates the version numbers in files "plugins/editors/codemirror/codemirror.xml" and "plugins/editors/tinymce/tinymce.xml", which has obviously been forgotten with a pervious update of these dependencies.
Testing Instructions
Code review: Check that the version number in the changed xml files fit to what is in file "package-lock.json".
For codemirror see https://github.com/joomla/joomla-cms/blob/5.0-dev/package-lock.json#L11934 .
For tinymce see https://github.com/joomla/joomla-cms/blob/5.0-dev/package-lock.json#L16196 .
Actual result BEFORE applying this Pull Request
Codemirror has 5.65.9 and tinymce has 6.2.0 in the XML file.
Expected result AFTER applying this Pull Request
Codemirror has 5.65.12 and tinymce has 6.4.0 in the XML file.
Link to documentations
Please select:
-
No documentation changes for docs.joomla.org needed
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40287.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.0-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40287.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-02 07:36:04 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks, but this should really be part of the bump script at some point
@HLeithner it is already part of the npm scripts that are responsible for handling changes created as a result of several dependencies.
@brianteeman sound great, do you know why it didn't worked?
it did work - the files were changed they were just not committed
ah ok thanks ;-)
thats why it is best to only change one thing in a PR. It is easy to see then that there were some changed files to commit from the npm update. You probably didnt see them when you made the pull request as there were so many other things in that PR. It's also why no one spotted it at the time of the pr
I have tested this item✅ successfully on 7db46ad
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40287.