[#40286] - [4.3] Fix SQL error "Can't Drop 'asset_id'; check that column/key exists" and checked out Guided Tours module when updating from 4.2.9 or older
- Fixed in Code Base
- 2 Apr 2023
- Medium
- Build: 4.3-dev
- # 40286
- Diff
- richard67:4.3-dev-fix-update-sql-for-guided-tours
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #40284 .
Summary of Changes
This pull request (PR) adds the "CAN FAIL" installer hint to the drop column statement in the "4.3.0-2023-03-28.sql" update script.
The reason is that with PR #40228 the update SQL script "4.3.0-2023-02-15.sql" has been changed, too, so the column does not exist when not updating from a 4.3.0 beta 4 or rc 1 but an older version.
In addition, this PR fixes the value of the checked out column of the Guided Tours module installed with the "4.3.0-2023-02-15.sql" script on update.
Testing Instructions
Update from a 4.2.9 or a current 4.2-dev branch to the last 4.3-dev nightly build to reproduce the issue, and to the update package or custom update URL built by drone for this PR to test the fix.
Actual result BEFORE applying this Pull Request
SQL error about column not existing.
Com_checkin shows something checked out in the modules table. Checking in database shows that it is the Guided Tours module.
Expected result AFTER applying this Pull Request
No SQL error.
Nothing is checked out in com_checkin after the update.
Link to documentations
Please select:
-
No documentation changes for docs.joomla.org needed
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Postgresql |
| Status | New | ⇒ | Pending |
| Labels |
Added:
Release Blocker
PR-4.3-dev
|
||
| Title |
|
||||||
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40286.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40286.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40286.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-02 12:06:13 |
| Closed_By | ⇒ | obuisard | |
| Labels |
Added:
?
|
||
Thank you Richard @richard67 for the PR and all for testing.
I have tested this item✅ successfully on ce538b6
new 4.2.9 instance
installed update file from 40286
installed without error
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40286.