[#40285] - [5.0] On a clean 5.0-dev branch, codemirror.xml and tinymce.xml are not up to date
- Closed
- 1 Apr 2023
- Medium
- Build: 4.3-dev
- # 40285
Steps to reproduce the issue
Check out the current 5.0-dev branch and make sure it is clean (e.g. with git clean -d -x -f and git checkout ..
Run git status.
Result: No changes are shown.
Check the version tags in files "plugins/editors/codemirror/codemirror.xml" and "plugins/editors/tinymce/tinymce.xml".
Result: Codemirror has 5.65.9, tinymce has 6.2.0.
Run composer install and npm ci.
Run git status and check the version tags in files "plugins/editors/codemirror/codemirror.xml" and "plugins/editors/tinymce/tinymce.xml".
Expected result
Still no changes are shown.
The version tags in the XML files should be the same before and after running "npm ci".
Actual result
Result of git status:
changed: plugins/editors/codemirror/codemirror.xml
changed: plugins/editors/tinymce/tinymce.xml
Result of version check in XML files:
Codemirror has 5.65.12, tinymce has 6.4.0.
System information (as much as possible)
Current 5.0-dev branch.
Additional comments
It seems the dependencies tinymce and codemirror have been updated in package.json, but the updated xml files have not been committed.
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
| Title |
|
||||||
yes that will fix the issue
the problem is because people keep updating npm and composer without looking at the files that are changed when they commit. Not the first time :(
yes that will fix the issue
the problem is because people keep updating npm and composer without looking at the files that are changed when they commit. Not the first time :(
@brianteeman Thanks for the feedback.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-01 19:31:21 |
| Closed_By | ⇒ | richard67 |
@brianteeman Asking you because I think you are familiar with updating the editors: Is is enough to commit the updated XML files for fixing this issue? I assume it is, but I'm not sure, maybe I'm missing something.