[#40288] - Guided Tours: Fix for Toggle Inline Help and Help buttons (Creating a step)
- Fixed in Code Base
- 4 Apr 2023
- Medium
- Build: 4.3-dev
- # 40288
- Diff
- Kostelano:4-3-Guided-Tours-Fix
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Partial solution for #40260.
- Go to the Guided Tours component,
- Go to the page with steps for any tour,
- Create a step,
Please note that there are no buttons Toggle Inline Help and Help in the toolbar on the right.
Apply PR and repeat the test - the buttons are now in place.
Because of the bracket, we have a duplicate of the buttons - Close and Cancel. The Cancel button has been removed because in tours we use Close. Fixed for dependency: Cancel on Create and Close on Edit (in tours and steps).
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
joomla-cms-bot
- | Category | ⇒ | Administration |
| Status | New | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40288.
| Labels |
Added:
PR-4.3-dev
|
||
Maybe. But firstly, it is also implemented when creating / editing a tour. Secondly, there are a lot of places in the system that contradict the way you wrote. Third, as you would (probably) write - this is outside the scope of this PR.
This should be conditional on the state. ie if its a new step then it it cancel. if it is an edit step then its a close
@brianteeman Can't sleep. Corrected
The last change looks better - can't test right now
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40288.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40288.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40288.
| Labels |
Added:
?
|
||
Kanstantin @Kostelano can you check the files on your end, there are not passing the drone because of end of line errors. Thanks!
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-04 18:42:57 |
| Closed_By | ⇒ | obuisard |
Thanks for the fix Konstantin @Kostelano
This should be conditional on the state. ie if its a new step then it it cancel. if it is an edit step then its a close