? NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
1 Apr 2023

Summary of Changes

fix call of Joomla.renderMessages

Testing Instructions

set an invalid data-id for example data-id="0"

<button type="button" class="button-start-guidedtour dropdown-item" data-id="<?php echo $tour->id ?>">

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

error message is rendered without js error
image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 1 Apr 2023
Category JavaScript Repository NPM Change
avatar heelc29 heelc29 - open - 1 Apr 2023
avatar heelc29 heelc29 - change - 1 Apr 2023
Status New Pending
avatar Quy Quy - test_item - 1 Apr 2023 - Tested successfully
avatar Quy
Quy - comment - 1 Apr 2023

I have tested this item successfully on 9d852f1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40282.

avatar richard67 richard67 - test_item - 1 Apr 2023 - Tested successfully
avatar richard67
richard67 - comment - 1 Apr 2023

I have tested this item successfully on 9d852f1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40282.

avatar richard67 richard67 - change - 1 Apr 2023
Status Pending Ready to Commit
Labels Added: NPM Resource Changed PR-4.3-dev
avatar richard67
richard67 - comment - 1 Apr 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40282.

avatar obuisard obuisard - change - 2 Apr 2023
Labels Added: ?
avatar obuisard obuisard - change - 2 Apr 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-04-02 12:49:40
Closed_By obuisard
avatar obuisard obuisard - close - 2 Apr 2023
avatar obuisard obuisard - merge - 2 Apr 2023
avatar obuisard
obuisard - comment - 2 Apr 2023

Thank you @heelc29 for the PR

Add a Comment

Login with GitHub to post a comment