PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
1 Apr 2023

Pull Request for Issue # .

Summary of Changes

This pull request (PR) removes the handling of legacy files of the Joomla Update component used when updating from 3.10 or 4.0.1 or an older 4.x version to a later 4.y version.

The handling of the legacy updater files had been added to version 4.0.2 with PR #35388 .

In detail the "restore_finalisation.php" had been replaced in the sources by "finalisation.php", and the file "restoration.php" which is generated during the update has been replaced by the generated file "update.php".

All this is removed by this PR here.

See also the text in the comment at the top of the removed "restore_finalisation.php" file:

 * This file can be safely removed once a new Joomla version is released which no longer provides an
 * update path from Joomla 3.x and older Joomla 4.0 versions. In theory, that would be Joomla 6.0 or
 * later.

As the update path to 5.x has to be from a 4.4 version, this is already fulfilled with 5.0 and not 6.0.

Testing Instructions

Code review of the changes here and the PR #35388 which had added the removed stuff.

Check that updating the latest 4.4-dev nightly build to the update package built by Drone for this PR here still works.

Actual result BEFORE applying this Pull Request

There is extra code for support of updating from 4.0.1 or older in the 5.0-dev branch.

Expected result AFTER applying this Pull Request

There is no extra code for support of updating from 4.0.1 or older in the 5.0-dev branch.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 1 Apr 2023
Category Administration com_joomlaupdate Repository
avatar richard67 richard67 - open - 1 Apr 2023
avatar richard67 richard67 - change - 1 Apr 2023
Status New Pending
avatar richard67 richard67 - change - 1 Apr 2023
The description was changed
avatar richard67 richard67 - edited - 1 Apr 2023
avatar HLeithner HLeithner - close - 2 Apr 2023
avatar HLeithner HLeithner - merge - 2 Apr 2023
avatar HLeithner HLeithner - change - 2 Apr 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-04-02 07:35:36
Closed_By HLeithner
Labels Added: PR-5.0-dev
avatar HLeithner
HLeithner - comment - 2 Apr 2023

thanks

Add a Comment

Login with GitHub to post a comment