[#40275] - Fix mod_articles_categories caching, allow CategoryNode serialization
- Fixed in Code Base
- 5 May 2023
- Medium
- Build: 4.3-dev
- # 40275
- Diff
- Denitz:Fix_mod_articles_categories_caching_and_CategoryNode_serialization
User tests: Successful: Unsuccessful:
Pull Request for Issue #38782.
Summary of Changes
- Caching of Articles Categories module fails because
CategoryNodetries to serializeCategorieswith database layer instance which is not technically serialazable due to presence ofClosureand i.e.PDOStatementobjects.
We need to allowCategoryNodeserialization.
Testing Instructions
- Enable Joomla caching.
- Create Articles Categories module to display lots of categories.
- Browse website as a guest.
Actual result BEFORE applying this Pull Request
See serialization error.
Expected result AFTER applying this Pull Request
No errors, module is cached.
Link to documentations
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End com_content Libraries Modules |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.3-dev
|
||
| Category | Front End com_content Libraries Modules | ⇒ | Libraries Modules Front End |
| Title |
|
||||||
@joomdonation Done, preload PR is #40279
I have tested this item
Works well for both cache on and off. Also tried to test the menu items which uses categories and it is still working well.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40275.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40275.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40275.
Hi Denitz, these fixes seem to have been committed to version 4.3.0 I updated to version 4.3.0 my module cache was disabled, I activated it again and it keeps returning the same error "0 Serialization of 'Closure' is not allowed"
| Labels |
Added:
?
bug
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-05 22:56:57 |
| Closed_By | ⇒ | obuisard |
@Denitz Many thanks for your work. May I suggest splitting your PR into two smaller ones
That would make it easier to test. I think the bug fix could go into 4.3 and the improvement could go to 4.4. As the current state of 4.3, Release Lead might not want to take the risk of too many changes.