User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This pull request (PR) removes obsolete exclude patterns from the "ruleset.xml" file which is used by phpcs e.g. in the ci tests with Drone.
Obsolete means the corresponding file or folder has been removed (or moved to another place) with some PR but the exclude pattern has been forgotten about.
In detail following entries are removed due to the mentioned PR:
The list of obsolete exclude patterns has been created with help of a small tool (PHP CLI script) which I provide with PR #40278 .
Which PR has caused each change has then been "manually" investigated by me.
Code review: Check that the removed exclude patterns belong to files mentioned in the list in the description above and the corresponding files don't exist on a clean, current 4.3-dev branch.
Verify that the PHPCS step succeeded in the Drone ci checks for this PR here.
File "ruleset.xml" in the Joomla root contains exclude patterns for files which don't exist anymore in the 4.3-dev branch.
File "ruleset.xml" in the Joomla root doesn't contain these exclude patterns.
PHPCS still succeeds in Drone for this PR.
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Labels |
Added:
bug
PR-4.3-dev
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-11 17:30:39 |
Closed_By | ⇒ | HLeithner |
Thanks
Thx