User tests: Successful: Unsuccessful:
Remove unnecessary escaping of double quotes since enclosed in single quotes.
Code review.
or
Install/update PR.
Category | ⇒ | SQL Administration com_admin Postgresql Installation |
Status | New | ⇒ | Pending |
I'm not sure if it's sufficient to test only by code review. The escape is definitely not necessary for the databases, but maybe the component needs that?
What happens if you add a new tour? Does it escape the quotes again in the extensions
column for the newly created records?
Labels |
Added:
PR-4.3-dev
|
Same as the other entries ["*"]
.
@Quy Except if you select some components, then it is e.g. ["com_content","com_categories"]
The question is now: Do we want to add a new update SQL which removes the escapes from beta 4 or rc1 or rc2 versions when updating? I am not sure if it needs that, but I know at least one person of whom I think he would want that.
Sorry I meant to say no \
required in the SQL files and not no double quotes in the table.
I've restored the previous test result in the issue tracker since the commit which invalidated the test count was just a clean branch update.
I have tested this item
I've verified that on both MySQL and PostgreSQL, the double quotes in the extensions
column are already stored in database without escaping when making anew installation without this PR applied. This means that it does not need a new update SQL script for fixing the values when updating 4.3 beta and RC versions because there would be nothing to fix.
I've also verified on both databases that a new installation with this PR applied works fine, there are no errors or warnings in the database server logs (except of the usual ones on PostgreSQL), and the values of the extensions
column are still right.
By review all SQL changes of this PR are correct.
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
bug
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-07 00:09:01 |
Closed_By | ⇒ | obuisard |
I have tested this item✅ successfully on d6494a7
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40274.