? bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
1 Apr 2023

Summary of Changes

Remove unnecessary escaping of double quotes since enclosed in single quotes.

Testing Instructions

Code review.
or
Install/update PR.

avatar joomla-cms-bot joomla-cms-bot - change - 1 Apr 2023
Category SQL Administration com_admin Postgresql Installation
avatar Quy Quy - open - 1 Apr 2023
avatar Quy Quy - change - 1 Apr 2023
Status New Pending
avatar chmst chmst - test_item - 1 Apr 2023 - Tested successfully
avatar chmst
chmst - comment - 1 Apr 2023

I have tested this item successfully on d6494a7

Code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40274.

avatar richard67
richard67 - comment - 1 Apr 2023

I'm not sure if it's sufficient to test only by code review. The escape is definitely not necessary for the databases, but maybe the component needs that?

What happens if you add a new tour? Does it escape the quotes again in the extensions column for the newly created records?

avatar Quy Quy - change - 1 Apr 2023
Labels Added: PR-4.3-dev
avatar Quy
Quy - comment - 1 Apr 2023

In the guidedtours table, there are no double quotes with fresh installations of the latest branch and prebuilt package of this PR.

40274

avatar richard67
richard67 - comment - 1 Apr 2023

@Quy And what happens if you create a new tour in backend so a new records gets added by PHP?

avatar richard67
richard67 - comment - 1 Apr 2023

@Quy I've just tested what I meant. It is ok, when adding a new tour in backend, the double quotes are also not escaped, so all fine.

avatar Quy
Quy - comment - 1 Apr 2023

Same as the other entries ["*"].

avatar richard67
richard67 - comment - 1 Apr 2023

@Quy Except if you select some components, then it is e.g. ["com_content","com_categories"] ?

The question is now: Do we want to add a new update SQL which removes the escapes from beta 4 or rc1 or rc2 versions when updating? I am not sure if it needs that, but I know at least one person of whom I think he would want that.

avatar Quy
Quy - comment - 1 Apr 2023

Sorry I meant to say no \ required in the SQL files and not no double quotes in the table.

avatar richard67 richard67 - alter_testresult - 9 Apr 2023 - chmst: Tested successfully
avatar richard67
richard67 - comment - 9 Apr 2023

I've restored the previous test result in the issue tracker since the commit which invalidated the test count was just a clean branch update.

avatar richard67 richard67 - test_item - 9 Apr 2023 - Tested successfully
avatar richard67
richard67 - comment - 9 Apr 2023

I have tested this item successfully on a8969e6

I've verified that on both MySQL and PostgreSQL, the double quotes in the extensions column are already stored in database without escaping when making anew installation without this PR applied. This means that it does not need a new update SQL script for fixing the values when updating 4.3 beta and RC versions because there would be nothing to fix.

I've also verified on both databases that a new installation with this PR applied works fine, there are no errors or warnings in the database server logs (except of the usual ones on PostgreSQL), and the values of the extensions column are still right.

By review all SQL changes of this PR are correct.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40274.

avatar richard67 richard67 - change - 9 Apr 2023
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 9 Apr 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40274.

avatar richard67 richard67 - change - 9 Apr 2023
Labels Added: ? bug
avatar obuisard obuisard - change - 7 May 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-05-07 00:09:01
Closed_By obuisard
avatar obuisard obuisard - close - 7 May 2023
avatar obuisard obuisard - merge - 7 May 2023
avatar obuisard
obuisard - comment - 7 May 2023

Thank you @Quy for the PR :-)

Add a Comment

Login with GitHub to post a comment