User tests: Successful: Unsuccessful:
Pull Request for Issue # .
This pull request (PR) removes the method "uninstallRepeatableFieldsPlugin" and calls to it from file "administrator/components/com_admin/script.php".
The method once had been added with PR #28319 for updating from 3.10 to 4.x and later been extended by diverse PR's for migration of repeatable fields to subforms.
The PR is one in a sequence of PR's for removing obsolete actions from script.php which are not relevant anymore because updates to 5.x will have to be done from a 4.4 version, like it is now with 4.x from 3.10.
Code review: Make sure that the removed method is not called anywhere else and that it does something which is definitely not needed when updating from 4.4 to 5.
Optional real test: Make sure that updating the latest 4.4-dev nightly build to the update package created by drone works when using the upload & update method.
Obsolete code for converting repeatable fields to subforms and removing the repeatable fields plugin when updating from 3.10 to 4.x is present in script.php.
Obsolete code for converting repeatable fields to subforms and removing the repeatable fields plugin when updating from 3.10 to 4.x is not present anymore in script.php.
Updating from a 4.4-dev nightly build works.
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed
Category | ⇒ | Administration com_admin |
Status | New | ⇒ | Pending |
Title |
|
Labels |
Added:
PR-5.0-dev
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-30 19:08:11 |
Closed_By | ⇒ | HLeithner |
thanks