No Code Attached Yet bug Guided Tours
avatar Kostelano
Kostelano
30 Mar 2023

Steps to reproduce the issue

The essence of the "Component Selector" parameter (displayed when creating a tour) is to hide / disable the display of the tour if the component itself is disabled / inactive.

It was explained to me below that this is not the case.

At first I just disabled the BANNERS component and saw that the tour did NOT become hidden. In this case, the link to the banner creation tour leads to 404 (logically).

In fact, there are definitely sites (on versions below 4.3), where the admins have disabled the use of certain components, to which the tour will be available in version 4.3. In this case, everyone will receive a 404 error. This needs to be fixed.

P. S. The logic of parameter "Component Selector" is correct, the tour is indeed hidden when the component is disabled.

avatar Kostelano Kostelano - open - 30 Mar 2023
avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2023
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 30 Mar 2023
avatar brianteeman
brianteeman - comment - 30 Mar 2023

actually the logic of the component selector is NOT what you think.

the idea of the component selector is that the tour will only show in the dropdown when you are in the component

image

image

avatar brianteeman
brianteeman - comment - 30 Mar 2023

You have actually discovered an important bug. If the banners component is not enabled then ther banners tour should not be enabled either. Not a big deal now but it will be if an extension adds a tour and then you uninstall the extension

avatar Kostelano
Kostelano - comment - 30 Mar 2023

Thanks for the clarification, it's clear now.

But I strongly disagree that at the moment it is not so important. There are sites whose admins disable the use of certain extensions (standard for Joomla, we are not even talking about installed ones). In this case, there will be a 404 error.

avatar obuisard
obuisard - comment - 30 Mar 2023

Agree that this is an issue.
The workaround for now is that you can just disable the tour of an extension if that core extension has been disabled.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40248.

avatar Kostelano Kostelano - change - 30 Mar 2023
The description was changed
avatar Kostelano Kostelano - edited - 30 Mar 2023
avatar Kostelano Kostelano - change - 30 Mar 2023
Title
Guided Tours: Parameter "Component Selector" and tours from Joomla distribution
Guided Tours: The tour is displayed even if the component is disabled
avatar Kostelano Kostelano - edited - 30 Mar 2023
avatar Quy Quy - change - 30 Mar 2023
Labels Added: bug
avatar Quy Quy - labeled - 30 Mar 2023
avatar GeraintEdwards
GeraintEdwards - comment - 3 Jul 2023

I would argue that this is not a bug in the guided tours code - rather its a problem in the tour itself. The banners tour should be constrained by the banner component at which point the problem goes away.

The "general" tours are 'introduction' type tours and perhaps there should be a different mechanism to select, group and present these.

avatar obuisard
obuisard - comment - 26 Jul 2024

In the case of core tours, when disabling an extension (like banners), the tours should be disabled automatically. When a third party extension installs a tour, the unistall of the third party extension should trigger the removal of the tour. Since the third party installs the tour, it should also take the responsibility to uninstall it.

avatar obuisard obuisard - change - 26 Jul 2024
Title
Guided Tours: The tour is displayed even if the component is disabled
[Guided tours] The tour is displayed even if the component is disabled
avatar obuisard obuisard - edited - 26 Jul 2024
avatar obuisard obuisard - change - 13 Sep 2024
Labels Added: Guided Tours
avatar obuisard obuisard - labeled - 13 Sep 2024

Add a Comment

Login with GitHub to post a comment