Feeling Lucky
?
PR-4.4-dev
[#40240] - Adding login module test for custom user
- Fixed in Code Base
- 4 Apr 2023
- Medium
- Build: 4.3-dev
- # 40240
- Diff
- charvimehradu:Users_login_cytest
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Adding login module test for custom user.
joomla-cms-bot
- | Category | ⇒ | JavaScript Unit Tests |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
PR-4.3-dev
|
||
| Labels |
Added:
PR-4.4-dev
|
||
laoneo
- comment
- 30 Mar 2023
Thank you very much for the pr. @Hackwar is right, this is a test for com_users. There is already a login module test, please add your code there https://github.com/joomla/joomla-cms/blob/4.4-dev/tests/System/integration/site/modules/mod_login/Default.cy.js. So we test then if the default user name works and from a custom user.
laoneo
- comment
- 31 Mar 2023
- Add your test to the file I mentioned before
- Write a similar test for the com_users login view
| Labels |
Removed:
PR-4.3-dev
|
||
| Title |
|
||||||
charvimehradu
- comment
- 1 Apr 2023
- Write a similar test for the com_users login view
Is it preferable to make a separate PR for this?
laoneo
- comment
- 1 Apr 2023
Good idea, so we can merge this one early.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-04 06:45:47 |
| Closed_By | ⇒ | laoneo |
laoneo
- comment
- 4 Apr 2023
Thanks!
This is a test of the login module, not the login view of com_users. My first change would be to visit index.php?option=com_users&view=login and then please check if the fields exist.