[#40239] - [4.4] Fixes to Form Field classes from static code analysis
- Fixed in Code Base
- 17 Apr 2023
- Medium
- Build: 4.4-dev
- # 40239
- Diff
- Hackwar:4.4-phan-form-fields
User tests: Successful: Unsuccessful:
Summary of Changes
These are several fixes to the Joomla\CMS\Form\Field classes based on static code analysis.
Testing Instructions
Codereview.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
bug
PR-4.4-dev
|
||
| Labels |
Removed:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-04-17 16:27:11 |
| Closed_By | ⇒ | laoneo |
and this breaks everything and should be reverted :(
Can you post here the error message you get? It looks like there is an issue with your setup. Also make sure you run composer install and npm ci on a clean branch 4.4-dev. Because the 130 system tests were passing fine, so a lot of views should work .
We are aware of the module error and @Hackwar cam up very quickly with a solution with #40403. But you wrote that everything is broken, so it looks like more an issue with your setup.
It was not only me who reviewed it, some other maintainers did as well. That's why I wanted to merge it early in the 4.4 release lifecycle to spot and fix such issues quickly.
Thanks!