? NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar obuisard
obuisard
30 Mar 2023

Pull Request for Issue #40211 .

Summary of Changes

Categories and tags are fancy select fields. Although tags can be selected in tours, categories can not.
This PR fixes categories and improves the tags selection fields.
Fields can be tabbed through, categories and tags selected (to select a category or tab, use the arrow keys) or added, as intended.

Testing Instructions

Take the article tour up to the category field.
Tab through to see that the popup and the field keep focus and you can go from one to the other.
Once it has focus, the field's dropdown should open (if you tab through or click on the field).
A category can be entered. To access already existing categories, use the arrow keys.
Press enter on the category and the article will change to the new category.
You will loose the 'back' button in the popup, since a refresh has been made.

Go down and test the tags the same way. This time there is no refresh when selecting tags.

Take the tour for guided tours. Check the component parameter as well.

Actual result BEFORE applying this Pull Request

You cannot select or add a category.

Expected result AFTER applying this Pull Request

You can select or add a category.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2023
Category SQL Administration com_admin Postgresql JavaScript Repository NPM Change Installation
avatar obuisard obuisard - open - 30 Mar 2023
avatar obuisard obuisard - change - 30 Mar 2023
Status New Pending
avatar khu5h1 khu5h1 - test_item - 30 Mar 2023 - Tested successfully
avatar khu5h1
khu5h1 - comment - 30 Mar 2023

I have tested this item successfully on b207e33


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40238.

avatar obuisard obuisard - change - 31 Mar 2023
Labels Added: NPM Resource Changed PR-4.3-dev
avatar obuisard
obuisard - comment - 31 Mar 2023

Khushi @khu5h1, do you mind testing again? Specifically the component field for the guided tours tour on new install.
Thanks in advance, I apologize for the mistake.

avatar obuisard obuisard - change - 31 Mar 2023
The description was changed
avatar obuisard obuisard - edited - 31 Mar 2023
avatar khu5h1 khu5h1 - test_item - 31 Mar 2023 - Tested successfully
avatar khu5h1
khu5h1 - comment - 31 Mar 2023

I have tested this item successfully on d8d7b7f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40238.

avatar Quy Quy - test_item - 31 Mar 2023 - Tested successfully
avatar Quy
Quy - comment - 31 Mar 2023

I have tested this item successfully on d8d7b7f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40238.

avatar Quy Quy - change - 31 Mar 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 31 Mar 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40238.

avatar Quy Quy - change - 31 Mar 2023
Labels Added: ?
avatar sdwjoomla sdwjoomla - close - 31 Mar 2023
avatar sdwjoomla sdwjoomla - merge - 31 Mar 2023
avatar sdwjoomla sdwjoomla - change - 31 Mar 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-03-31 21:31:33
Closed_By sdwjoomla

Add a Comment

Login with GitHub to post a comment