? Language Change PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
25 Mar 2023

Summary of Changes

Make filter search tooltip consistent with other tooltips.

Testing Instructions

Code review.

avatar joomla-cms-bot joomla-cms-bot - change - 25 Mar 2023
Category Administration Language & Strings
avatar Quy Quy - open - 25 Mar 2023
avatar Quy Quy - change - 25 Mar 2023
Status New Pending
avatar brianteeman
brianteeman - comment - 25 Mar 2023

The PR is correct for consistency but if you check you will see that there is no code for searching the descrption

avatar Quy
Quy - comment - 25 Mar 2023

Please see this merged PR #40118 to see code for description search.

avatar brianteeman
brianteeman - comment - 25 Mar 2023

The query still fails with that merged pr

backend

avatar brianteeman brianteeman - test_item - 25 Mar 2023 - Tested successfully
avatar brianteeman
brianteeman - comment - 25 Mar 2023

I have tested this item successfully on 498f435

the change to the string is correct


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40197.

avatar Quy
Quy - comment - 25 Mar 2023

The language constants and not values are stored in the tables, thus, no match found.

40198

avatar brianteeman
brianteeman - comment - 25 Mar 2023

no thats not it. the query is supposed to take account of that (and it works for the title)

avatar Quy Quy - change - 29 Mar 2023
Title
[4.3] Make filter search tooltip consistent
[4.3][Guided Tours] Make filter search tooltip consistent
avatar Quy Quy - edited - 29 Mar 2023
avatar Kostelano Kostelano - test_item - 31 Mar 2023 - Tested successfully
avatar Kostelano
Kostelano - comment - 31 Mar 2023

I have tested this item successfully on 498f435


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40197.

avatar Quy Quy - change - 31 Mar 2023
Status Pending Ready to Commit
Labels Added: PR-4.3-dev
avatar Quy
Quy - comment - 31 Mar 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40197.

avatar Quy Quy - change - 31 Mar 2023
Labels Added: ?
avatar Quy Quy - change - 31 Mar 2023
Labels Added: Language Change
avatar sdwjoomla sdwjoomla - change - 1 Apr 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-04-01 15:22:14
Closed_By sdwjoomla
avatar sdwjoomla sdwjoomla - close - 1 Apr 2023
avatar sdwjoomla sdwjoomla - merge - 1 Apr 2023

Add a Comment

Login with GitHub to post a comment