Feature No Code Attached Yet Guided Tours
avatar brianteeman
brianteeman
25 Mar 2023

Steps to reproduce the issue

try to search for anything in the description using the syntax DESCRIPTION: xxxxxx
eg DESCRIPTION: backend

backend

Expected result

1 match

Actual result

0 matches

System information (as much as possible)

Additional comments

avatar brianteeman brianteeman - open - 25 Mar 2023
avatar joomla-cms-bot joomla-cms-bot - change - 25 Mar 2023
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 25 Mar 2023
avatar GeraintEdwards
GeraintEdwards - comment - 3 Jul 2023

I see two ways this could be resolved in the code:

  1. Load all the tours into memory and translate them into the currently active language - could possibly streamline by only looking in tours with 'translated' values
  2. Search through all the relevant language files for matching text - could be very complicated once we have tours from multiple vendors with more complex langugage file naming conventions.

Approach 1 could be performed a 'page'/'display limit' at a time - until you have enough results that match.

Either way the search is done by PHP and not he database.

The only other thought I have is to store the translations of the tour fields in the database

avatar Hackwar Hackwar - change - 22 Aug 2023
Labels Added: Feature
avatar Hackwar Hackwar - labeled - 22 Aug 2023
avatar obuisard
obuisard - comment - 26 Jul 2024

The same goes with Workflows. As long as the search key that is entered is part of the language key (in English), it's fine. Any other time, it's not.
So this should be addressed more generally in Joomla core.

avatar obuisard obuisard - change - 26 Jul 2024
Title
[4.3] guided tours - description search
[4.3] [Guided tours] description search
avatar obuisard obuisard - edited - 26 Jul 2024
avatar obuisard obuisard - change - 26 Jul 2024
Title
[4.3] [Guided tours] description search
[4.3] [Guided tours] description/step search
avatar obuisard obuisard - edited - 26 Jul 2024
avatar brianteeman
brianteeman - comment - 29 Jul 2024

the same might be true for workflows but searching there will be used far less often.

avatar obuisard
obuisard - comment - 29 Jul 2024

the same might be true for workflows but searching there will be used far less often.

Definitely.

avatar obuisard obuisard - change - 13 Sep 2024
Labels Added: Guided Tours
avatar obuisard obuisard - labeled - 13 Sep 2024

Add a Comment

Login with GitHub to post a comment