[#40080] - Fix domain checking for request
- Fixed in Code Base
- 12 Mar 2023
- Medium
- Build: 4.3-dev
- # 40080
- Diff
- Fedik:fix39969
User tests: Successful: Unsuccessful:
Pull Request for Issue #39969 and #39970 and #39580.
Alternative to PR #39970 .
Summary of Changes
Better checking for domain
Testing Instructions
Apply patch, run npm install
Please follow #39969
Actual result BEFORE applying this Pull Request
Installation broken
Expected result AFTER applying this Pull Request
Installation works
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Status | New | ⇒ | Pending |
| Labels |
Added:
NPM Resource Changed
PR-4.3-dev
|
||
This is alternative
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40080.
So I tested it and it solved the issue. Sending test mail from Global Configuration is still working, too
However, there is one case which I think the test does not pass. Assume the current site is http://localhost/joomla42, if ajax request make to http://localhost/joomla43, the token is still send. It's not a big thing, I guess, so if you confirm that it is OK, I will report my test result @Fedik
Tuan @joomdonation can you confirm the test is ok and report in the issue tracker? Thank you!
I have tested this item
Not 100% accurate but should be OK.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40080.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40080.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-12 13:12:03 |
| Closed_By | ⇒ | obuisard | |
| Labels |
Added:
Release Blocker
|
||
Assume the current site is http://localhost/joomla42, if ajax request make to http://localhost/joomla43, the token is still send
As long as you an owner of the domain, that should be fine :)
@Fedik Is this an alternative for PR #39970 ? Or is it an addition to it?